update slo to return error after decoding

signalfx · Nov 7, 2024 · 4541e93 · 4541e93
1 parent 1a7d4ce
commit 4541e93
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/slo.go b/slo.go
@@ -56,12 +56,13 @@ func (c *Client) executeSloRequest(ctx context.Context, url string, method strin
 		return nil, err
 	}
 
-	if resp.Body != nil {
-		returnedSlo := &slo.SloObject{}
-		err = json.NewDecoder(resp.Body).Decode(returnedSlo)
-		return returnedSlo, nil
-	} else {
+	if expectedValidStatus == http.StatusNoContent {
 		_, _ = io.Copy(io.Discard, resp.Body)
 		return nil, nil
 	}
+
+	returnedSlo := &slo.SloObject{}
+	err = json.NewDecoder(resp.Body).Decode(returnedSlo)
+	_, _ = io.Copy(io.Discard, resp.Body)
+	return returnedSlo, err
 }