-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize the OpenTelemetry demo for Splunk #1
Conversation
Splunk otel updates
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Can we develop a script (example) or GitHub workflow to automate the synchronization of this demo with the upstream source? It's crucial to either automate the update process or provide detailed documentation for the process. This will facilitate incorporating changes from the upstream project over time. |
Thanks for the example script @jvoravong , I'll see what I can do. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@jvoravong FYI, I've made good progress on automating the process of applying my changes to the upstream version, but still have work to do before the PR is ready to be reviewed. |
Hi @jvoravong - the requested changes are ready for your review. To make future merges with upstream straightforward, the only files changed are in a new folder named "splunk". Everything else is aligned with upstream exactly. A new script was added named "update-demos.sh" that can be run after merging with upstream to regenerate the splunk-specific config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits. LGTM overall.
Thanks @jvoravong , I've made the suggested changes. I believe @atoulme is the owner of this repo and will need to approve the merge. |
@jvoravong you should have powers to merge now. |
Changes
I've made a number of customizations to the upstream OpenTelemetry demo for use with Splunk Cloud/Enterprise and Splunk Observability Cloud. These include:
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.