Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate text format for profiling.data.format #285

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Deprecate text format for profiling.data.format #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c08e20a
Deprecate `text` format for `profiling.data.format`
Kielek Dec 27, 2023
31039c2
Update semantic_conventions.md
pellared Dec 28, 2023
7f8bc6f
Update CHANGELOG.md
pellared Dec 28, 2023
38abe90
Update CHANGELOG.md
pellared Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@
- Change `telemetry.auto.version` to `telemetry.distro.version`,
- Add `telemetry.distro.name` resource attribute.

### Semantic Conventions

#### Enhancements

- Deprecate `text` format for `profiling.data.format`. (#285)

## [1.6.0] - 2023-09-14

### Configuration
Expand Down Expand Up @@ -72,7 +78,7 @@

- Remove `telemetry.sdk.language` attribute from `ResourceLogs.resource`.

### Bugfixes
#### Bugfixes

- Remove redunant and conflicting statement about file and line for `ResourceLogs`.

Expand Down
5 changes: 4 additions & 1 deletion specification/semantic_conventions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,10 @@ instances. For each `LogRecord` instance:

- `com.splunk.sourcetype` MUST be set to the value `otel.profiling`
- `profiling.data.type` MUST be set to either `allocation` or `cpu`
- `profiling.data.format` MUST be set to either `text` or `pprof-gzip-base64`
- `profiling.data.format` MUST be set to either:
- `pprof-gzip-base64`,
- `text` ([Deprecated](../README.md#versioning-and-status-of-the-specification)
format).

#### `LogRecord` Message `text` Data Format Specific Attributes

Expand Down