Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify default sampler #284

Merged
merged 11 commits into from
Nov 26, 2024
Merged
17 changes: 12 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,19 @@

#### Enhancements

- Require a CLA Assistant GitHub workflow. (#269)
- Update the CLA notice in `CONTRIBUTING.md` template. (#269, #274)
- Add Renovate as an acceptable alternative to Dependabot. (#271)
- Clarify the default sampling algorithm.
[#284](https://github.com/signalfx/gdi-specification/pull/284)
- Require a CLA Assistant GitHub workflow.
[#269](https://github.com/signalfx/gdi-specification/pull/269)
- Update the CLA notice in `CONTRIBUTING.md` template.
[#269](https://github.com/signalfx/gdi-specification/pull/269)
[#274](https://github.com/signalfx/gdi-specification/pull/274)
- Add Renovate as an acceptable alternative to Dependabot.
[#271](https://github.com/signalfx/gdi-specification/pull/271)
- Add disk buffering configuration options for RUM mobile instrumentation
libraries. (#275)
- Update telemetry resource attributes (#277):
libraries. [#275](https://github.com/signalfx/gdi-specification/pull/275)
- Update telemetry resource attributes
[#277](https://github.com/signalfx/gdi-specification/pull/277):
- Deprecate `splunk.distro.version`,
- Change `telemetry.auto.version` to `telemetry.distro.version`,
- Add `telemetry.distro.name` resource attribute.
Expand Down
4 changes: 4 additions & 0 deletions specification/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,10 @@ are required.
telemetry directly to Splunk Observability Cloud.
```

- `OTEL_TRACES_SAMPLER`
- Distribution MUST default to `always_on`
(not OpenTelemetry default)

In addition to environment variables, other ways of defining configuration also exist:

- [Java System
Expand Down