Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/pane-layout): provide close/open event and default slot #1563

Merged
merged 11 commits into from
Nov 21, 2024

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Nov 14, 2024

💡 What is the current behavior?

GitHub Issue Number: Closes #1512, [IX-1829]

  • user don't get notified, before the user expands the pane via the icon button
  • users have to name the slot in the pane-layout in order to utilize it

🆕 What is the new behavior?

  • Close event provided, with the option to prevent the event (prevent from opening / closing)
  • besides the a default fallback have been provided.
  • Note: A better name for the event could be provided

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: e71fa4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix-angular Minor
@siemens/ix Minor
@siemens/ix-vue Minor
@siemens/ix-aggrid Patch
@siemens/ix-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthiashader matthiashader marked this pull request as draft November 14, 2024 13:53
@matthiashader matthiashader changed the title fix(core/ix-pane-layout): provide close/open event and default slot feat(core/ix-pane-layout): provide close/open event and default slot Nov 14, 2024
@matthiashader matthiashader changed the title feat(core/ix-pane-layout): provide close/open event and default slot feat(core/pane-layout): provide close/open event and default slot Nov 18, 2024
@matthiashader matthiashader marked this pull request as ready for review November 18, 2024 06:45
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not provide dedicated expand and collapse events?

.changeset/seven-coins-fly.md Outdated Show resolved Hide resolved
@danielleroux danielleroux marked this pull request as draft November 19, 2024 15:09
@matthiashader matthiashader marked this pull request as ready for review November 20, 2024 08:30
.changeset/seven-coins-fly.md Outdated Show resolved Hide resolved
Co-authored-by: Lukas Maurer <[email protected]>
Copy link

sonarcloud bot commented Nov 21, 2024

@nuke-ellington nuke-ellington dismissed jul-lam’s stale review November 21, 2024 09:29

Changeset was updated

@nuke-ellington nuke-ellington merged commit d6da6ad into main Nov 21, 2024
15 checks passed
@nuke-ellington nuke-ellington deleted the fix/1829-pane-layout branch November 21, 2024 09:30
This was referenced Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add close event to ix-pane
3 participants