Skip to content

Commit

Permalink
feat(core): form component overhaul (#1318)
Browse files Browse the repository at this point in the history
  • Loading branch information
danielleroux authored Nov 21, 2024
1 parent 8e72ec8 commit f5af78e
Show file tree
Hide file tree
Showing 677 changed files with 32,373 additions and 9,845 deletions.
27 changes: 27 additions & 0 deletions .changeset/modern-comics-grow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
---
'@siemens/ix-angular': minor
'@siemens/ix-react': minor
'@siemens/ix': minor
'@siemens/ix-vue': minor
---

Introduce several new input components:

- `ix-input` for text based inputs
- `ix-number-input` for number based inputs with optional stepper buttons
- `ix-date-input` which shows a date picker within a dropdown
- `ix-textarea` for larger text inputs
- `ix-radio` and `ix-radio-group`
- `ix-checkbox`
- `ix-custom-field` to wrap custom components

Introduce a new layout component `ix-layout-auto` to make it easier to create a typical input forms.

Enhanced the compatibility with Forms for the following components:

- `ix-select`
- `ix-toggle`

> _Deprecation:_
>
> Native css stylings for `input` and `textarea` (e.g `input[type="checkbox"]` and `input[type="radio"]`) are deprecated and will be removed in upcoming major release.
5 changes: 5 additions & 0 deletions .changeset/olive-peaches-march.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@siemens/ix": patch
---

__ix-drawer__: the full-height property is now working
5 changes: 5 additions & 0 deletions .changeset/polite-crews-camp.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@siemens/ix": patch
---

Remove `border-radius` from `<input />` if `readonly` or `disable` is set
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ node_modules
*.launch
.settings/
*.sublime-workspace
.obsidian

# IDE - VSCode
.vscode/*
Expand Down
25 changes: 23 additions & 2 deletions SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,27 @@ This source code is licensed under the MIT license found in the
LICENSE file in the root directory of this source tree.
-->

# Reporting Security Issues
# Security Policy

If you believe you have found a security vulnerability in iX, we encourage you to let us know right away. We will investigate all legitimate reports and do our best to quickly fix the problem.
Siemens takes the security of its code seriously. If you think you have found a security vulnerability,
please read the next sections and follow the instructions to report your finding.

## Scope of this policy

This is the default security policy for all repositories within the `siemens` organization on GitHub.com.

It does not apply for reposities that have their own security policy.
It also does not apply for forks where you should follow the upstream policy instead.

If you are unsure whether the policy applies feel free to reach out via the channels mentioned below and we'll be happy to help.

## Reporting a Vulnerability

Please DO NOT report any potential security vulnerability via a public channel (mailing list, GitHub issue, etc.).
Instead, [report the vulnerability privately via GitHub](https://docs.github.com/en/code-security/security-advisories/guidance-on-reporting-and-writing/privately-reporting-a-security-vulnerability)
(if enabled for the repository) or [contact us via email](mailto:[email protected]).

Please provide a detailed description of the issue, the steps to reproduce it, the affected version(s) and, if already available,
a proposal for a fix. You should receive a response within 5 working days. If for some reason you do not, please follow up via email to ensure we received your original message.

If we confirm the issue as a vulnerability, we will publish an advisory (e.g. on GitHub) and give credits for your report if desired. We follow the [coordinated vulnerability disclosure](https://vuls.cert.org/confluence/display/CVD) model and will define an appropriate disclosure timeline together with you.
7 changes: 7 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"start": "dotenv -- turbo run start",
"turbo": "dotenv -- turbo",
"lint": "dotenv -- turbo run lint",
"format": "prettier --write ./packages/**/src/**/*.{ts,tsx,js,jsx,css,scss,html,vue,json}",
"changelog": "conventional-changelog -p angular -i CHANGELOG.md -s -r 0",
"visual-regression": "dotenv -- turbo run visual-regression",
"test": "dotenv -- turbo run test",
Expand Down Expand Up @@ -61,5 +62,11 @@
"commitizen": {
"path": "./node_modules/cz-conventional-changelog"
}
},
"pnpm": {
"patchedDependencies": {
"@stencil/[email protected]": "patches/@[email protected]",
"@stencil/[email protected]": "patches/@[email protected]"
}
}
}
11 changes: 11 additions & 0 deletions packages/aggrid/scss/ix-aggrid.scss
Original file line number Diff line number Diff line change
Expand Up @@ -157,5 +157,16 @@
.ag-radio-button .ag-input-wrapper {
color: var(--theme-color-primary);
}

.ag-input-field-input {
&.focus,
&:focus {
&:not(.readonly, .read-only, .disabled, [readonly], [disabled], :read-only) {
outline: 1px solid var(--theme-color-focus-bdr) !important;
outline-offset: var(--theme-input--focus--outline-offset) !important;
border-color: var(--theme-input--border-color--focus) !important;
}
}
}
}
}
1 change: 1 addition & 0 deletions packages/aggrid/tests/aggrid.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ regressionTest.describe('aggrid', () => {
await expect(filterMenu).toBeVisible();

const inputHandle = filterMenu.getByPlaceholder('Filter...');
await inputHandle.click();
await inputHandle.fill('Test');

expect(await page.screenshot({ fullPage: true })).toMatchSnapshot();
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit f5af78e

Please sign in to comment.