Add a setting to ignore some protocols when listening #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidoh
reviewed
Nov 23, 2024
web2/api/api-zod.ts
Outdated
| @@ -576,30 +582,6 @@ const TransitionData = TransitionArgs.and( | |||
| .passthrough() | |||
| ); | |||
| const postTransitions_Body = TransitionData.and(BulbId); | |||
| const PacketMessage = z | |||
There was a problem hiding this comment.
Make sure to run the generator with --export-schemas. This gets used.
|
Looks good! openapi spec changes look right. In general if it produces the right types for the frontend it's fine. There are some integration tests written in ruby that should probably be updated with the new setting. I'm happy to take that, though. Might be worth creating a new section for "listening." Can put listen repeats, listen channel and this new setting under there. |
|
I made a new section "📡 Listening" and fixed the generated parts |
|
Great! Thanks very much for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
ignored_listen_protocolssetting to filter out unnecessary protocols. This improves the receive reliability as discussed in the linked issue.Closes #845
I decided to use an ignore list rather than a whitelist because any new protocols will always be enabled by default.
Screenshot:
Maybe it is not really fitting with the repeats category, it could also be put under the listen channel select.
Also please check my openapi changes, I have no experience with how to use that.