mail sent save and cancelled event is implemented in iOS #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This pull request aims to address an issue mentioned in GitHub Issue #72 related to the iOS mail sending functionality in the Flutter Email Sender plugin.
Bug Description
In the iOS environment, there was a discrepancy observed in the event handling for mail sending. Specifically, the events were returned prematurely, sometimes before the user returned to the app, creating inconsistency in the expected behavior.
Proposed Changes
Implemented event handling for all iOS mail sending options using an enumerated structure to ensure comprehensive coverage and proper handling of different scenarios.
Modified the event handling logic specifically for iOS 17 to resolve the issue of events returning before the user's return to the application, ensuring synchronization with the user's actions.
Impact and Testing
The changes included in this PR were thoroughly tested across various iOS versions, with a focus on iOS 17, to verify the resolution of the premature event issue. Additionally, these changes did not affect the functionality on other platforms.
Contributor Note
Developers reviewing this pull request are encouraged to examine the changes made in event handling for iOS, especially focusing on iOS 17 compatibility, and ensure the resolution of the reported issue without adverse effects on the plugin's functionality across different iOS versions.
This summary provides an overview of the problem, the proposed changes, their impact, and encourages reviewers to pay particular attention to the iOS 17 compatibility and event handling modifications.