feat: implement new address sorting algorithm #9847
Draft
+126
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes siderolabs#9725 See siderolabs#9749 Signed-off-by: Andrey Smirnov <[email protected]>
|
I'm not sure how to configure sorting algorithm (is the machine config not too late?). Probably safe to keep old defaults. tl;dr is trying to drop alphanumeric sort on resource IDs in favor of proper comparison which includes putting shorter prefixes first. heavy WIP at the moment, mostly refactoring |
smira
commented
Nov 29, 2024
| } | ||
|
|
||
| // if addresses are equal, compare prefix lengths | ||
| return cmp.Compare(a.Bits(), b.Bits()) |
There was a problem hiding this comment.
should be -cmp.Compare probably
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9725
See #9749