feat: support image cache copying #9845
Merged
+840
−206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
reviewed
Nov 29, 2024
| } | ||
|
|
||
| dstStat, err := os.Stat(dst) | ||
| if err == nil && srcStat.Size() == dstStat.Size() { |
There was a problem hiding this comment.
two files could haave the same size, but hashing is expensive
There was a problem hiding this comment.
that would be outside of our control I guess, we just try to skip copying what is already there
frezbo
reviewed
Nov 29, 2024
frezbo
reviewed
Nov 29, 2024
frezbo
reviewed
Nov 29, 2024
frezbo
reviewed
Nov 29, 2024
DmitriyMV
reviewed
Nov 29, 2024
DmitriyMV
reviewed
Nov 29, 2024
smira
force-pushed
the
feat/image-cache-copy
branch
from
f2238a1
to
7208d00
Compare
DmitriyMV
reviewed
Nov 29, 2024
DmitriyMV
reviewed
Nov 29, 2024
DmitriyMV
reviewed
Nov 29, 2024
DmitriyMV
approved these changes
Nov 29, 2024
Fixes siderolabs#9615 The are no integration tests, this is to be addressed later. I did manual tests so far. Also includes first draft of the documentation. Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
feat/image-cache-copy
branch
from
7208d00
to
770be16
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9615
The are no integration tests, this is to be addressed later. I did manual tests so far.
Also includes first draft of the documentation.