Docs - update method 5 in deploying-cilium.md #9495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Frąckiewicz <[email protected]>
smira
reviewed
Oct 15, 2024
| - --set | ||
| - kubeProxyReplacement=true | ||
| - --set | ||
| - securityContext.privileged=true |
There was a problem hiding this comment.
I'm not sure about this, we don't seem to be setting this anywhere, and not used in the tests.
The formatting of arguments was certainly wrong, and thanks for fixing
|
This PR is stale because it has been open 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes #9494
What? (description)
Fix guide to install Cilium via Cilium CLI on Talos
Why? (reasoning)
Cilium CLI changes broken current docs
Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)