Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support global config patches which can be applied to all machines #5

Closed
wants to merge 1 commit into from
Closed

feat: support global config patches which can be applied to all machines #5

wants to merge 1 commit into from

Conversation

Unix4ever
Copy link
Member

The provider now has --config-patch cmd line argument which can configure it to create config patches for each created machine.

@Unix4ever
feat: support global config patches which can be applied to all machines
18bd814 
The provider now has `--config-patch` cmd line argument which can
configure it to create config patches for each created machine.

Signed-off-by: Artem Chernyshev <[email protected]>
smira
smira previously approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for KubeSpanEndoints? as I guess it should be specific for each machine

@smira smira self-requested a review November 12, 2024 16:46
@smira smira dismissed their stale review November 12, 2024 16:47

misclicked

@Unix4ever
Copy link
Member Author

is this for KubeSpanEndoints? as I guess it should be specific for each machine

Well, maybe not for each machine, but rather per cluster as there will be a loadbalancer

@smira
Copy link
Member

smira commented Nov 12, 2024

is this for KubeSpanEndoints? as I guess it should be specific for each machine

Well, maybe not for each machine, but rather per cluster as there will be a loadbalancer

KubeSpan endpoint can't be per-cluster, it's totally a per-machine thing I believe. So the provider should create a Service, and once that Service is ready, inject a proper endpoint as a config patch. (That's my understanding)

@Unix4ever
Copy link
Member Author

is this for KubeSpanEndoints? as I guess it should be specific for each machine

Well, maybe not for each machine, but rather per cluster as there will be a loadbalancer

KubeSpan endpoint can't be per-cluster, it's totally a per-machine thing I believe. So the provider should create a Service, and once that Service is ready, inject a proper endpoint as a config patch. (That's my understanding)

Oh I see. I guess we need some other solution for that then.

@Unix4ever Unix4ever closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smira smira Awaiting requested review from smira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Unix4ever @smira @talos-bot