Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Passt Network Binding Plugin for IPv6 environments. #3

Closed
wants to merge 3 commits into from
Closed

Support Passt Network Binding Plugin for IPv6 environments. #3

wants to merge 3 commits into from

Conversation

trevex
Copy link
Contributor

@trevex trevex commented Oct 30, 2024

Changes required to use different network binding plugin for IPv6 environments.

@trevex trevex force-pushed the main branch 2 times, most recently from 6df640b to a3715aa Compare November 4, 2024 13:31
@trevex
feat: allow specifying network binding via flag to be able to
bca1091 
accommodate Passt in IPv6 environments

Signed-off-by: Niklas Voss <[email protected]>
@trevex trevex force-pushed the main branch 3 times, most recently from 6e65d8f to b9abee7 Compare November 4, 2024 13:41
@trevex trevex marked this pull request as ready for review November 4, 2024 13:42
@trevex
Copy link
Contributor Author

trevex commented Nov 4, 2024

@Unix4ever The PR should now be ready, but not sure why conform/commit/gpg-identity is failing. GPG key is published to ubuntu and openpgp keyserver.

@trevex
Copy link
Contributor Author

trevex commented Nov 7, 2024

Alternatively I can also refactor the code to get network configuration from provider data instead.
That is how I added support to configure the target namespace to provision to (future PR: trevex@283a744).

@trevex
Copy link
Contributor Author

trevex commented Nov 7, 2024

I am assuming the conform check is failing due to this: https://github.com/siderolabs/omni-infra-provider-kubevirt/blob/main/.conform.yaml#L12

@Unix4ever
Copy link
Member

Unix4ever commented Nov 11, 2024 •
edited
Loading

@Unix4ever The PR should now be ready, but not sure why conform/commit/gpg-identity is failing. GPG key is published to ubuntu and openpgp keyserver.

This is expected. The PR is needed to be signed by one of the Sidero employees.

Alternatively I can also refactor the code to get network configuration from provider data instead.

I think that's a good idea. You can make it optional with the default value of bridge type.

I will sign and merge the PR when it's ready.

@trevex
feat: configure network binding through provider data instead
5acbb45 
Expose network binding in provider schema to allow configuration of
KubeVirt network binding on a per MachineClass-basis.

Signed-off-by: Niklas Voss <[email protected]>
@trevex
Copy link
Contributor Author

trevex commented Nov 11, 2024

Done, once this is merged I'll create another PR to configure target namespace through provider data as well.

@Unix4ever
Copy link
Member

Unix4ever commented Nov 12, 2024 •
edited
Loading

Ah, I won't be able to merge this PR as it's created from the main branch of your fork.
I will recreate the PR using your commit in my fork

For the future, please create a branches in your fork :)

@Unix4ever
Copy link
Member

replaced with #4

@Unix4ever Unix4ever closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unix4ever Unix4ever Unix4ever approved these changes

Assignees

@Unix4ever Unix4ever

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trevex @Unix4ever