Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for s3 bucket in provisioner (#668) #917

Closed
wants to merge 4 commits into from

Conversation

Shubham8287
Copy link
Contributor

@Shubham8287 Shubham8287 commented May 15, 2023

  • feat: update provisioner.proto to add methods for provisioning storage

  • feat: implemented provision_storage to create a bucket and return user credentials to access the bucket

This is a provisioner side change for task /attempt #668, Steps for provisioning storage look like -

  • Create a S3 bucket by appending an uuid to project_name to make it globally unique.
  • Create a User to interact with the bucket
  • Create a Policy and attach that to User
  • Return access keys for the user, so that resource builder can access the bucket.

* feat: update provisioner.proto to add methods for provisioning storage

* feat: implmented provision_storage to create bucket and return user credential to access bucket
@Shubham8287 Shubham8287 marked this pull request as draft May 15, 2023 07:51
@Shubham8287
Copy link
Contributor Author

@oddgrd , @chesedo I would love to get some early eye on PR to make sure I am going on right direction.
This PR addresses provisioner-side changes for adding s3 resources. I marked it as a draft as I am yet to finalize policies to grant to new users and write tests. Though, I did the end-to-end testing by making a GRPC call to provisioner server using my personal aws account.
PS: I am new to Rust, and I tried to write stuff well but there can be some cracking lines especially the error handling part as I find that a little tricky in Rust. I am looking to learn so you can go hard while reviewing :)

@iulianbarbu
Copy link
Contributor

Hey @Shubham8287 ! Thanks a lot for taking a stab at S3 resource. We'll be providing some feedback soon on this PR.

@oddgrd oddgrd requested a review from iulianbarbu June 2, 2023 12:38
@jonaro00 jonaro00 mentioned this pull request Jun 12, 2023
@Shubham8287
Copy link
Contributor Author

Changes has been added in #995

@Shubham8287 Shubham8287 closed this Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants