feat: add dynamodb resource #910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t - passing cargo check
…ture/dynamodb-resource
|
Issue #895 |
mikegin
force-pushed
the
feature/dynamodb-resource
branch
from
19a3239
to
6a9cac4
Compare
…ce lib.rs so available in example
Only the "cloud" version of the provisioner needs to delete tables if the dynamodb resource is deleted.
Closed
Shubham8287
reviewed
Jun 17, 2023
Shubham8287
reviewed
Jun 17, 2023
iulianbarbu
force-pushed
the
feature/dynamodb-resource
branch
from
1392880
to
530b254
Compare
|
@mikegin @paulotten FYI, I synced this branch with |
iulianbarbu
force-pushed
the
feature/dynamodb-resource
branch
from
daa4dd3
to
3a62ea3
Compare
chesedo
reviewed
Jul 5, 2023
There was a problem hiding this comment.
@iulianbarbu I left two comments. This seems about ready, thanks!
iulianbarbu
reviewed
Jul 5, 2023
oddgrd
added
the
S-Blocked
|
Hey @mikegin and @paulotten, we're going to close this as blocked until we can figure out how we will securily provision this resource. Thanks for all your hard work on this, we're sorry we couldn't get this over the line, it looked really great, and we'll likely return to your implementation in the future when we decide on the design. This PR also made it very clear which problem we need to solve next, so thanks for that too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamoDB auto connection
Auto connection to the first Key Value store on Shuttle 🥳🚀
Big shoutout to @paulotten for taking the lead on this task