Support empty first series in stack #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can easily happen when series of different length are drawn and the RangeSlider is used to restrict the graph to a range where one of the series is empty.
|
Any chance you can also take a look at this while you're at it? :) |
dchester
added a commit
that referenced
this pull request
Apr 2, 2014
Support empty first series in stack
Indeed -- very creative! |
|
:-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the RangeSlider on a graph with data of different lengths of series, it can easily happen that the displayed region is one where some of the series have no data.
If this happens to be the first series, then Rickshaw will barf, as it's internal domain() calculation cannot cope with that.
This patch expands the power of the domain() calculation and adds some lenience into the validation routine of Rickshaw.Graph to make it easier to unit test that situation.
This pull request probably obsoletes /pull/244 and closes /issues/122.
Do you like it?
Do you want any changes in implementation to accept this?
Best regards,
Martin