-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Eq
and Default
derivations to structs
#116
Conversation
This commit ensures key structs implement `Eq` and `Default` for consistency and ease of use. It enhances type capabilities in `nonfungible_position_manager.rs` and `abi.rs`. Additionally, it updates the package version to 2.9.1 in `Cargo.toml`.
WalkthroughAdjusts glasses Fascinating! This pull request represents a minor version increment for the Uniswap V3 SDK, involving precise modifications to the package's version and type system. The changes enhance struct definitions and trait implementations across multiple files, focusing on improving type safety and equality comparisons with surgical precision. Changes
Possibly related PRs
Poem
Knocks on imaginary door Bazinga! Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🔇 Additional comments (3)Cargo.toml (1)
The minor version bump from 2.9.0 to 2.9.1 perfectly aligns with semantic versioning principles for adding new trait derivations. src/abi.rs (1)
The systematic application of Also applies to: 41-41, 60-60, 74-74, 92-92, 116-116, 127-127, 165-165, 225-225, 252-252, 272-272, 286-286, 297-297, 311-311 src/nonfungible_position_manager.rs (1)
The addition of Also applies to: 27-27 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This commit ensures key structs implement
Eq
andDefault
for consistency and ease of use. It enhances type capabilities innonfungible_position_manager.rs
andabi.rs
. Additionally, it updates the package version to 2.9.1 inCargo.toml
.Summary by CodeRabbit
New Features
Bug Fixes
Documentation