Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow partial tag list to be retrieved #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow partial tag list to be retrieved #10

wants to merge 1 commit into from

Conversation

ArnaudBenassy
Copy link

The idea is to avoid full retrieval of tags if not necessary.
In my case, it was necessary to avoid loading of a corrupted Image attached in APIC, that was causing application to crach unexpectedly with certains MP3s.

No BC break, readAllTags continue to work as expected, redirecting to readTags with list from Id3Tags::getId3Tags()

Attached test is running a different Id3TagsReader instance to permit partial load.

@shubhamjain
Copy link
Owner

Seems ok but why $tagsToRetrieve needs to be an associative array. Doesn't a simple list make more sense? And believe, the two if conditions in the while loop could be optimised and made more cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants