Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collector custom arguments #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aoblet
Copy link
Contributor

@aoblet aoblet commented Nov 6, 2018

This allows to:

  • interact with hook collector at runtime
  • based on user input, modulate some item properties

By refactoring the way we prepare arguments to run_process_file and run_process_file, maybe that _get_process_args is less easier to read than before.. What do you think ?

@coveralls
Copy link

coveralls commented Nov 6, 2018

Coverage Status

Coverage increased (+0.9%) to 87.182% when pulling e23599d on mikrosimage:collection_args into dbf952c on shotgunsoftware:master.

In that way, we can:
- interact with collector hooks at runtime
- modulate the item properties based on user input
This shows that we can use external data inside collector hooks
@thebeeland
Copy link
Contributor

Thanks so much for sending this our way, @aoblet. I've logged an internal ticket to have it reviewed, so we will take a closer look as soon as we can.

@thebeeland thebeeland added the Logged Logged in Jira label Nov 12, 2018
@jfboismenu
Copy link
Contributor

Hi @aoblet , I'm sorry we haven't been able to get back to your PR yet. I think I may have given the impression when we were discussing on Zendesk that we'd look at this right away, but it's become clear to us that we're kinda slammed at the moment and are not able to take the time we need to review client PRs and take them through the finish line. I'm deeply sorry about this.

Have you had success using these changes in production? Is there anything you feel like you'd like to improve?

@aoblet
Copy link
Contributor Author

aoblet commented Dec 7, 2018

No worries. On our side, these changes are in production and are doing the job.

@eprana
Copy link

eprana commented Mar 8, 2021

@aoblet @jfboismenu Hi guys, any update about this PR ?

@charltk
Copy link

charltk commented Jan 12, 2022

Hi @eprana - could you tell us a little more about how you've been using this functionality in production? I'm curious about the specific use cases that you've been able to address with the collector custom arguments that weren't possible before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Logged Logged in Jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants