This repository has been archived by the owner on Dec 27, 2020. It is now read-only.
Add neutral animation #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicoder10
suggested changes
Aug 30, 2020
Comment on lines
+38
to
40
| className={classNames(`${styles.face}`, { | ||
| [`${styles.face_active}`]: this.props.isActive | ||
| })} |
There was a problem hiding this comment.
Suggested change
| className={classNames(`${styles.face}`, { | |
| [`${styles.face_active}`]: this.props.isActive | |
| })} | |
| className={classNames({ | |
| [styles.face]: true, | |
| [styles.face_active]: this.props.isActive | |
| })} |
| width="60" height="60" viewBox="0 0 100 100" | ||
| > | ||
| <circle className={`${styles.face__background}`} cx="49.5" cy="49.5" r="49.5"/> | ||
| <circle className={`${styles.face__eyesAndMouth} face__eyesAndMouth`} cx="21.6" cy="50.7" r="6"/> |
There was a problem hiding this comment.
Suggested change
| <circle className={`${styles.face__eyesAndMouth} face__eyesAndMouth`} cx="21.6" cy="50.7" r="6"/> | |
| <circle className={`${styles.face__eyesAndMouth}`} cx="21.6" cy="50.7" r="6"/> |
| > | ||
| <circle className={`${styles.face__background}`} cx="49.5" cy="49.5" r="49.5"/> | ||
| <circle className={`${styles.face__eyesAndMouth} face__eyesAndMouth`} cx="21.6" cy="50.7" r="6"/> | ||
| <circle className={`${styles.face__eyesAndMouth} face__eyesAndMouth`} cx="77.4" cy="50.7" r="6"/> |
There was a problem hiding this comment.
Suggested change
| <circle className={`${styles.face__eyesAndMouth} face__eyesAndMouth`} cx="77.4" cy="50.7" r="6"/> | |
| <circle className={`${styles.face__eyesAndMouth}`} cx="77.4" cy="50.7" r="6"/> |
| <circle className={`${styles.face__background}`} cx="49.5" cy="49.5" r="49.5"/> | ||
| <circle className={`${styles.face__eyesAndMouth} face__eyesAndMouth`} cx="21.6" cy="50.7" r="6"/> | ||
| <circle className={`${styles.face__eyesAndMouth} face__eyesAndMouth`} cx="77.4" cy="50.7" r="6"/> | ||
| <path className={`${styles.face__eyesAndMouth} face__eyesAndMouth`} d={neutralMouthSVGPath}/> |
There was a problem hiding this comment.
Suggested change
| <path className={`${styles.face__eyesAndMouth} face__eyesAndMouth`} d={neutralMouthSVGPath}/> | |
| <path className={`${styles.face__eyesAndMouth}`} d={neutralMouthSVGPath}/> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added animation component for neutral reaction face.
I followed https://en.bem.info/methodology/naming-convention/ while naming css classes.
Screenshots of final result: