resolved missing typehints reported to be introduced in next package …

…versions
shopsys · Nov 25, 2024 · d455afa · d455afa
1 parent fd5b4d5
commit d455afa
Show file tree

Hide file tree

Showing 26 changed files with 26 additions and 40 deletions.
diff --git a/src/Component/Constraints/CustomerUserRoleGroup.php b/src/Component/Constraints/CustomerUserRoleGroup.php
@@ -17,9 +17,8 @@ class CustomerUserRoleGroup extends Constraint
 
     /**
      * @var array<string, string>
-     * @phpcsSuppress SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
      */
-    protected static $errorNames = [
+    protected const array ERROR_NAMES = [
         self::CUSTOMER_USER_ROLE_GROUP_NOT_FOUND => 'CUSTOMER_USER_ROLE_GROUP_NOT_FOUND',
     ];
 

diff --git a/src/Component/Constraints/CustomerUserRoleGroupAllowEdit.php b/src/Component/Constraints/CustomerUserRoleGroupAllowEdit.php
@@ -20,9 +20,8 @@ class CustomerUserRoleGroupAllowEdit extends Constraint
 
     /**
      * @var array<string, string>
-     * @phpcsSuppress SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
      */
-    protected static $errorNames = [
+    protected const array ERROR_NAMES = [
         self::CUSTOMER_USER_ROLE_GROUP_CANNOT_BE_CHANGED => 'CUSTOMER_USER_ROLE_GROUP_CANNOT_BE_CHANGED',
         self::LAST_CUSTOMER_USER_ROLE_GROUP_CANNOT_BE_CHANGED => 'LAST_CUSTOMER_USER_ROLE_GROUP_CANNOT_BE_CHANGED',
     ];

diff --git a/src/Component/Constraints/CustomerUserRoleGroupAllowEditValidator.php b/src/Component/Constraints/CustomerUserRoleGroupAllowEditValidator.php
@@ -31,7 +31,7 @@ public function __construct(
      * @param mixed $value
      * @param \Symfony\Component\Validator\Constraint $constraint
      */
-    public function validate($value, Constraint $constraint): void
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof CustomerUserRoleGroupAllowEdit) {
             throw new UnexpectedTypeException($constraint, CustomerUserRoleGroupAllowEdit::class);

diff --git a/src/Component/Constraints/CustomerUserRoleGroupValidator.php b/src/Component/Constraints/CustomerUserRoleGroupValidator.php
@@ -24,7 +24,7 @@ public function __construct(
      * @param mixed $value
      * @param \Symfony\Component\Validator\Constraint $constraint
      */
-    public function validate($value, Constraint $constraint)
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof CustomerUserRoleGroup) {
             throw new UnexpectedTypeException($constraint, CustomerUserRoleGroup::class);

diff --git a/src/Component/Constraints/DeliveryAddressUuid.php b/src/Component/Constraints/DeliveryAddressUuid.php
@@ -14,9 +14,8 @@ class DeliveryAddressUuid extends Constraint
 
     /**
      * @var array<string, string>
-     * @phpcsSuppress SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
      */
-    protected static $errorNames = [
+    protected const array ERROR_NAMES = [
         self::LOGIN_REQUIRED_ERROR => 'LOGIN_REQUIRED_ERROR',
     ];
 

diff --git a/src/Component/Constraints/DeliveryAddressUuidValidator.php b/src/Component/Constraints/DeliveryAddressUuidValidator.php
@@ -24,7 +24,7 @@ public function __construct(
      * {@inheritdoc}
      */
     #[Override]
-    public function validate($value, Constraint $constraint): void
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof DeliveryAddressUuid) {
             throw new UnexpectedTypeException($constraint, DeliveryAddressUuid::class);

diff --git a/src/Component/Constraints/FileUpload.php b/src/Component/Constraints/FileUpload.php
@@ -14,10 +14,8 @@ class FileUpload extends Constraint
 
     /**
      * @var array<string, string>
-     * @phpcsSuppress SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
-     * @phpcsSuppress SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnlySniff.ReferenceViaFullyQualifiedName
      */
-    protected static $errorNames = [
+    protected const array ERROR_NAMES = [
         self::TOO_BIG_ERROR => 'TOO_BIG_ERROR',
         self::UPLOAD_ERROR => 'UPLOAD_ERROR',
         self::MIMETYPE_ERROR => 'MIMETYPE_ERROR',

diff --git a/src/Component/Constraints/FileUploadValidator.php b/src/Component/Constraints/FileUploadValidator.php
@@ -16,7 +16,7 @@ class FileUploadValidator extends ConstraintValidator
      * @param mixed $value
      * @param \Symfony\Component\Validator\Constraint $constraint
      */
-    public function validate($value, Constraint $constraint): void
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof FileUpload) {
             throw new UnexpectedTypeException($constraint, FileUpload::class);

diff --git a/src/Component/Constraints/PaymentInCart.php b/src/Component/Constraints/PaymentInCart.php
@@ -17,9 +17,8 @@ class PaymentInCart extends Constraint
 
     /**
      * @var array<string, string>
-     * @phpcsSuppress SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
      */
-    protected static $errorNames = [
+    protected const array ERROR_NAMES = [
         self::UNAVAILABLE_PAYMENT_ERROR => 'UNAVAILABLE_PAYMENT_ERROR',
         self::INVALID_PAYMENT_TRANSPORT_COMBINATION_ERROR => 'INVALID_PAYMENT_TRANSPORT_COMBINATION_ERROR',
     ];

diff --git a/src/Component/Constraints/PaymentInCartValidator.php b/src/Component/Constraints/PaymentInCartValidator.php
@@ -32,7 +32,7 @@ public function __construct(
      * @param mixed $value
      * @param \Shopsys\FrontendApiBundle\Component\Constraints\PaymentInCart $constraint
      */
-    public function validate($value, Constraint $constraint)
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof PaymentInCart) {
             throw new UnexpectedTypeException($constraint, PaymentInCart::class);

diff --git a/src/Component/Constraints/PaymentInExistingOrder.php b/src/Component/Constraints/PaymentInExistingOrder.php
@@ -20,9 +20,8 @@ class PaymentInExistingOrder extends Constraint
 
     /**
      * @var array<string, string>
-     * @phpcsSuppress SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
      */
-    protected static $errorNames = [
+    protected const array ERROR_NAMES = [
         self::UNAVAILABLE_PAYMENT_ERROR => 'UNAVAILABLE_PAYMENT_ERROR',
         self::UNCHANGEABLE_PAYMENT_ERROR => 'UNCHANGEABLE_PAYMENT_ERROR',
         self::INVALID_PAYMENT_SWIFT_ERROR => 'INVALID_PAYMENT_SWIFT_ERROR',

diff --git a/src/Component/Constraints/PaymentInExistingOrderValidator.php b/src/Component/Constraints/PaymentInExistingOrderValidator.php
@@ -35,7 +35,7 @@ public function __construct(
      * @param mixed $value
      * @param \Symfony\Component\Validator\Constraint $constraint
      */
-    public function validate($value, Constraint $constraint): void
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof PaymentInExistingOrder) {
             throw new UnexpectedTypeException($constraint, PaymentInExistingOrder::class);

diff --git a/src/Component/Constraints/PaymentInOrder.php b/src/Component/Constraints/PaymentInOrder.php
@@ -20,9 +20,8 @@ class PaymentInOrder extends Constraint
 
     /**
      * @var array<string, string>
-     * @phpcsSuppress SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
      */
-    protected static $errorNames = [
+    protected const array ERROR_NAMES = [
         self::PAYMENT_NOT_SET_ERROR => 'PAYMENT_NOT_SET_ERROR',
         self::UNAVAILABLE_PAYMENT_ERROR => 'UNAVAILABLE_PAYMENT_ERROR',
         self::CHANGED_PAYMENT_PRICE_ERROR => 'CHANGED_PAYMENT_PRICE_ERROR',

diff --git a/src/Component/Constraints/PaymentInOrderValidator.php b/src/Component/Constraints/PaymentInOrderValidator.php
@@ -29,7 +29,7 @@ public function __construct(
      * @param mixed $value
      * @param \Shopsys\FrontendApiBundle\Component\Constraints\PaymentInOrder $constraint
      */
-    public function validate($value, Constraint $constraint)
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof PaymentInOrder) {
             throw new UnexpectedTypeException($constraint, PaymentInOrder::class);

diff --git a/src/Component/Constraints/PaymentTransportRelation.php b/src/Component/Constraints/PaymentTransportRelation.php
@@ -17,9 +17,8 @@ class PaymentTransportRelation extends Constraint
 
     /**
      * @var array<string, string>
-     * @phpcsSuppress SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
      */
-    protected static $errorNames = [
+    protected const array ERROR_NAMES = [
         self::INVALID_COMBINATION_ERROR => 'INVALID_COMBINATION_ERROR',
     ];
 

diff --git a/src/Component/Constraints/PaymentTransportRelationValidator.php b/src/Component/Constraints/PaymentTransportRelationValidator.php
@@ -26,7 +26,7 @@ public function __construct(
      * @param mixed $value
      * @param \Symfony\Component\Validator\Constraint $constraint
      */
-    public function validate($value, Constraint $constraint): void
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof PaymentTransportRelation) {
             throw new UnexpectedTypeException($constraint, PaymentTransportRelation::class);

diff --git a/src/Component/Constraints/ProductInOrder.php b/src/Component/Constraints/ProductInOrder.php
@@ -14,9 +14,8 @@ class ProductInOrder extends Constraint
 
     /**
      * @var array<string, string>
-     * @phpcsSuppress SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
      */
-    protected static $errorNames = [
+    protected const array ERROR_NAMES = [
         self::NO_PRODUCT_IN_ORDER_ERROR => 'NO_PRODUCT_IN_ORDER_ERROR',
     ];
 

diff --git a/src/Component/Constraints/ProductInOrderValidator.php b/src/Component/Constraints/ProductInOrderValidator.php
@@ -26,7 +26,7 @@ public function __construct(
      * @param mixed $value
      * @param \Shopsys\FrontendApiBundle\Component\Constraints\ProductInOrder $constraint
      */
-    public function validate($value, Constraint $constraint): void
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof ProductInOrder) {
             throw new UnexpectedTypeException($constraint, ProductInOrder::class);

diff --git a/src/Component/Constraints/PromoCode.php b/src/Component/Constraints/PromoCode.php
@@ -38,9 +38,8 @@ class PromoCode extends Constraint
 
     /**
      * @var array<string, string>
-     * @phpcsSuppress SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
      */
-    protected static $errorNames = [
+    protected const array ERROR_NAMES = [
         self::INVALID_ERROR => 'INVALID_ERROR',
         self::NOT_YET_VALID_ERROR => 'NOT_YET_VALID_ERROR',
         self::NO_LONGER_VALID_ERROR => 'NO_LONGER_VALID_ERROR',

diff --git a/src/Component/Constraints/PromoCodeValidator.php b/src/Component/Constraints/PromoCodeValidator.php
@@ -36,7 +36,7 @@ public function __construct(
      * @param mixed $value
      * @param \Symfony\Component\Validator\Constraint $constraint
      */
-    public function validate($value, Constraint $constraint)
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof PromoCode) {
             throw new UnexpectedTypeException($constraint, PromoCode::class);

diff --git a/src/Component/Constraints/TransportInCart.php b/src/Component/Constraints/TransportInCart.php
@@ -26,9 +26,8 @@ class TransportInCart extends Constraint
 
     /**
      * @var array<string, string>
-     * @phpcsSuppress SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
      */
-    protected static $errorNames = [
+    protected const array ERROR_NAMES = [
         self::UNAVAILABLE_TRANSPORT_ERROR => 'UNAVAILABLE_TRANSPORT_ERROR',
         self::UNAVAILABLE_PICKUP_PLACE_ERROR => 'UNAVAILABLE_PICKUP_PLACE_ERROR',
         self::WEIGHT_LIMIT_EXCEEDED_ERROR => 'WEIGHT_LIMIT_EXCEEDED_ERROR',

diff --git a/src/Component/Constraints/TransportInCartValidator.php b/src/Component/Constraints/TransportInCartValidator.php
@@ -42,7 +42,7 @@ public function __construct(
      * @param mixed $value
      * @param \Shopsys\FrontendApiBundle\Component\Constraints\TransportInCart $constraint
      */
-    public function validate($value, Constraint $constraint)
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof TransportInCart) {
             throw new UnexpectedTypeException($constraint, TransportInCart::class);

diff --git a/src/Component/Constraints/TransportInOrder.php b/src/Component/Constraints/TransportInOrder.php
@@ -29,9 +29,8 @@ class TransportInOrder extends Constraint
 
     /**
      * @var array<string, string>
-     * @phpcsSuppress SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
      */
-    protected static $errorNames = [
+    protected const array ERROR_NAMES = [
         self::TRANSPORT_NOT_SET_ERROR => 'TRANSPORT_NOT_SET_ERROR',
         self::TRANSPORT_UNAVAILABLE_ERROR => 'TRANSPORT_UNAVAILABLE_ERROR',
         self::CHANGED_TRANSPORT_PRICE_ERROR => 'CHANGED_TRANSPORT_PRICE_ERROR',

diff --git a/src/Component/Constraints/TransportInOrderValidator.php b/src/Component/Constraints/TransportInOrderValidator.php
@@ -34,7 +34,7 @@ public function __construct(
      * @param mixed $value
      * @param \Symfony\Component\Validator\Constraint $constraint
      */
-    public function validate($value, Constraint $constraint)
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof TransportInOrder) {
             throw new UnexpectedTypeException($constraint, TransportInOrder::class);

diff --git a/src/Component/Constraints/UniqueBillingAddressApi.php b/src/Component/Constraints/UniqueBillingAddressApi.php
@@ -17,9 +17,8 @@ class UniqueBillingAddressApi extends Constraint
 
     /**
      * @var array<string, string>
-     * @phpcsSuppress SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
      */
-    protected static $errorNames = [
+    protected const array ERROR_NAMES = [
         self::DUPLICATE_BILLING_ADDRESS => 'DUPLICATE_BILLING_ADDRESS',
     ];
 

diff --git a/src/Component/Constraints/UniqueBillingAddressApiValidator.php b/src/Component/Constraints/UniqueBillingAddressApiValidator.php
@@ -30,7 +30,7 @@ public function __construct(
      * @param mixed $value
      * @param \Symfony\Component\Validator\Constraint $constraint
      */
-    public function validate($value, Constraint $constraint)
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof UniqueBillingAddressApi) {
             throw new UnexpectedTypeException($constraint, UniqueBillingAddressApi::class);