[shopsys] Upgraded to PHP 8.3 (#3002)

shopsys · Feb 9, 2024 · c243736 · c243736
2 parents 53c82d0 + 884d343
commit c243736
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/.github/workflows/run-checks-tests.yaml b/.github/workflows/run-checks-tests.yaml
@@ -15,7 +15,7 @@ jobs:
             -   name: Install PHP, extensions and tools
                 uses: shivammathur/setup-php@v2
                 with:
-                    php-version: '8.1'
+                    php-version: '8.3'
                     extensions: bcmath, gd, intl, pdo_pgsql, redis, pgsql, zip
                     tools: composer
             -   name: Install Composer dependencies

diff --git a/build.xml b/build.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project name="frontend_api">
-    <property name="env.lang.english" value="LANG=en_US.UTF-8"/>
     <property name="path.openssl.executable" value="openssl"/>
 
     <target name="frontend-api-generate-new-keys" depends="production-protection" description="Generates keys and parameter for signing tokens.">
@@ -40,8 +39,8 @@
             <arg value="graphql"/>
             <arg value="--modern"/>
         </exec>
-        <exec executable="${env.lang.english}" passthru="true" checkreturn="true">
-            <arg value="node"/>
+        <exec executable="node" passthru="true" checkreturn="true">
+            <env key="LANG" value="en_US.UTF-8"/>
             <arg value="${path.node_modules.bin}/format-graphql"/>
             <arg value="--write"/>
             <arg value="${path.root}/schema.graphql"/>

diff --git a/composer.json b/composer.json
@@ -21,7 +21,7 @@
         }
     },
     "require": {
-        "php": "^8.1",
+        "php": "^8.3",
         "elasticsearch/elasticsearch": "^7.6.1",
         "lcobucci/jwt": "^4.1.5",
         "overblog/graphql-bundle": "^1.0",

diff --git a/src/Component/ExpressionLanguage/DynamicPaginationComplexityExpressionFunction.php b/src/Component/ExpressionLanguage/DynamicPaginationComplexityExpressionFunction.php
@@ -11,7 +11,7 @@ class DynamicPaginationComplexityExpressionFunction extends ExpressionFunction
     public function __construct()
     {
         parent::__construct('dynamicPaginationComplexity', function (string $args = '[]', string $oneItemComplexity = '1', string $defaultCount = '10') {
-            return '\\' . ComplexityCalculator::class . "::calculate(${args}, ${oneItemComplexity}, ${defaultCount})";
+            return '\\' . ComplexityCalculator::class . "::calculate({$args}, {$oneItemComplexity}, {$defaultCount})";
         });
     }
 }