sorting products by type is now more extendable

shopsys · Nov 6, 2024 · 2385345 · 2385345
1 parent 6aef288
commit 2385345
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 1 deletion.
diff --git a/src/Model/Product/Elasticsearch/ProductExportRepository.php b/src/Model/Product/Elasticsearch/ProductExportRepository.php
@@ -187,6 +187,8 @@ protected function getExportedFieldValue(int $domainId, Product $product, string
             ProductExportFieldProvider::ACCESSORIES => $this->extractAccessoriesIds($product),
             ProductExportFieldProvider::HREFLANG_LINKS => $this->hreflangLinksFacade->getForProduct($product, $domainId),
             ProductExportFieldProvider::PRODUCT_TYPE => $this->extractProductType($product, $domainId),
+            ProductExportFieldProvider::PRIORITY_BY_PRODUCT_TYPE => $this->extractPriorityByProductType($product, $domainId),
+
             default => throw new InvalidArgumentException(sprintf('There is no definition for exporting "%s" field to Elasticsearch', $field)),
         };
     }
@@ -331,6 +333,22 @@ protected function extractProductType(Product $product, int $domainId): string
         return $product->getProductType();
     }
 
+    /**
+     * @param \Shopsys\FrameworkBundle\Model\Product\Product $product
+     * @param int $domainId
+     * @return int
+     */
+    protected function extractPriorityByProductType(Product $product, int $domainId): int
+    {
+        $productType = $this->extractProductType($product, $domainId);
+
+        return match ($productType) {
+            ProductTypeEnum::TYPE_BASIC => 20,
+            ProductTypeEnum::TYPE_INQUIRY => 10,
+            default => -100,
+        };
+    }
+
     /**
      * @param int $domainId
      * @param \Shopsys\FrameworkBundle\Model\Product\Product $product

diff --git a/src/Model/Product/Elasticsearch/Scope/ProductExportFieldProvider.php b/src/Model/Product/Elasticsearch/Scope/ProductExportFieldProvider.php
@@ -44,6 +44,7 @@ class ProductExportFieldProvider
     public const string ACCESSORIES = 'accessories';
     public const string HREFLANG_LINKS = 'hreflang_links';
     public const string PRODUCT_TYPE = 'product_type';
+    public const string PRIORITY_BY_PRODUCT_TYPE = 'priority_by_product_type';
 
     /**
      * @return string[]

diff --git a/src/Model/Product/Search/FilterQuery.php b/src/Model/Product/Search/FilterQuery.php
@@ -75,7 +75,7 @@ public function applyOrdering(string $orderingModeId, PricingGroup $pricingGroup
         ];
 
         if ($orderingModeId === ProductListOrderingConfig::ORDER_BY_PRIORITY) {
-            $clone->sorting['product_type'] = 'asc';
+            $clone->sorting['priority_by_product_type'] = 'desc';
             $clone->sorting['ordering_priority'] = 'desc';
             $clone->sorting['name.keyword'] = 'asc';
 

diff --git a/src/Model/Product/Search/ProductElasticsearchConverter.php b/src/Model/Product/Search/ProductElasticsearchConverter.php
@@ -55,6 +55,7 @@ public function fillEmptyFields(array $product): array
         $result['seo_meta_description'] = $product['seo_meta_description'] ?? null;
         $result['hreflang_links'] = $product['hreflang_links'] ?? [];
         $result['product_type'] = $product['product_type'] ?? ProductTypeEnum::TYPE_BASIC;
+        $result['priority_by_product_type'] = $product['priority_by_product_type'] ?? 0;
 
         return $result;
     }

diff --git a/tests/Unit/Model/Product/Search/ProductElasticsearchConverterTest.php b/tests/Unit/Model/Product/Search/ProductElasticsearchConverterTest.php
@@ -54,6 +54,7 @@ public function testFillEmptyFields(): void
             'seo_meta_description' => null,
             'hreflang_links' => [],
             'product_type' => 'basic',
+            'priority_by_product_type' => 0,
         ];
 
         $converter = new ProductElasticsearchConverter();
@@ -120,6 +121,7 @@ public function testFillEmptyParameterFields(): void
             'seo_meta_description' => null,
             'hreflang_links' => [],
             'product_type' => 'basic',
+            'priority_by_product_type' => 0,
         ];
 
         $converter = new ProductElasticsearchConverter();