restore ff tests

shoelace-style · Nov 21, 2023 · b6c9b64 · b6c9b64
1 parent 00435ac
commit b6c9b64
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/src/components/color-picker/color-picker.test.ts b/src/components/color-picker/color-picker.test.ts
@@ -385,8 +385,7 @@ describe('<sl-color-picker>', () => {
     expect(blurHandler).to.have.been.calledOnce;
   });
 
-  // NOTE: Firefox is failing locally for me even though manual tests show this is working fine
-  it.skip('should emit sl-focus when rendered inline and focused', async () => {
+  it('should emit sl-focus when rendered inline and focused', async () => {
     const el = await fixture<SlColorPicker>(html`
       <div>
         <sl-color-picker inline></sl-color-picker>
@@ -410,8 +409,7 @@ describe('<sl-color-picker>', () => {
     expect(blurHandler).to.have.been.calledOnce;
   });
 
-  // NOTE: Firefox is failing locally for me even though manual tests show this is working fine
-  it.skip('should focus and blur when calling focus() and blur() and rendered as a dropdown', async () => {
+  it('should focus and blur when calling focus() and blur() and rendered as a dropdown', async () => {
     const colorPicker = await fixture<SlColorPicker>(html` <sl-color-picker></sl-color-picker> `);
     const focusHandler = sinon.spy();
     const blurHandler = sinon.spy();

diff --git a/src/components/dialog/dialog.test.ts b/src/components/dialog/dialog.test.ts
@@ -149,8 +149,7 @@ describe('<sl-dialog>', () => {
   });
 
   // https://github.com/shoelace-style/shoelace/issues/1382
-  // NOTE: Firefox is failing locally for me even though manual tests show this is working fine
-  it.skip('should properly cycle through tabbable elements when sl-dialog is used in a shadowRoot', async () => {
+  it('should properly cycle through tabbable elements when sl-dialog is used in a shadowRoot', async () => {
     class AContainer extends LitElement {
       get dialog() {
         return this.shadowRoot?.querySelector('sl-dialog');

diff --git a/src/components/select/select.test.ts b/src/components/select/select.test.ts
@@ -443,8 +443,7 @@ describe('<sl-select>', () => {
   });
 
   describe('when resetting a form', () => {
-    // NOTE: Firefox is failing locally for me even though manual tests show this is working fine
-    it.skip('should reset the element to its initial value', async () => {
+    it('should reset the element to its initial value', async () => {
       const form = await fixture<HTMLFormElement>(html`
         <form>
           <sl-select value="option-1">