improve range/tooltip perf; fixes #2064 (#2237)

shoelace-style · Oct 28, 2024 · 80c3d87 · 80c3d87
1 parent aca0f3d
commit 80c3d87
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/docs/pages/resources/changelog.md b/docs/pages/resources/changelog.md
@@ -17,6 +17,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti
 - Added support for <kbd>Enter</kbd> to `<sl-split-panel>` to align with ARIA APG's [window splitter pattern](https://www.w3.org/WAI/ARIA/apg/patterns/windowsplitter/) [#2234]
 - Fixed a bug in `<sl-carousel>` that caused the navigation icons to be reversed
 - Fixed a bug in `<sl-select>` that prevented label changes in `<sl-option>` from updating the controller [#1971]
+- Improved performance of `<sl-range>` by skipping positioning logic when tooltip isn't shown [#2064]
 
 ## 2.18.0
 

diff --git a/src/components/range/range.component.ts b/src/components/range/range.component.ts
@@ -215,7 +215,7 @@ export default class SlRange extends ShoelaceElement implements ShoelaceFormCont
 
     this.syncProgress(percent);
 
-    if (this.tooltip !== 'none') {
+    if (this.tooltip !== 'none' && this.hasTooltip) {
       // Ensure updates are drawn before we sync the tooltip
       this.updateComplete.then(() => this.syncTooltip(percent));
     }