Always done on end

shockpkg · Oct 2, 2023 · 4187ca9 · 4187ca9
1 parent 1d948a8
commit 4187ca9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/archive/zip.ts b/src/archive/zip.ts
@@ -49,7 +49,7 @@ const yauzlEntryReadSymlink = async (
 	entry: yauzl.Entry
 ) => {
 	const stream = await yauzlEntryRead(zipfile, entry);
-	return stream ? streamToBuffer(stream, 'end') : Buffer.alloc(0);
+	return stream ? streamToBuffer(stream) : Buffer.alloc(0);
 };
 
 export interface IZipEntryExtraField {

diff --git a/src/util.ts b/src/util.ts
@@ -170,13 +170,9 @@ export function zipPathIsMacResource(path: string) {
  * This is however useful for some small streams.
  *
  * @param stream Readable stream.
- * @param doneEvent The stream done event.
  * @returns Full buffer.
  */
-export async function streamToBuffer(
-	stream: Readable,
-	doneEvent: string = 'end'
-) {
+export async function streamToBuffer(stream: Readable) {
 	const buffer = await new Promise<Buffer>((resolve, reject) => {
 		const datas: Buffer[] = [];
 		let once = false;
@@ -203,7 +199,7 @@ export async function streamToBuffer(
 		stream.on('error', err => {
 			done(err);
 		});
-		stream.on(doneEvent, () => {
+		stream.on('end', () => {
 			done();
 		});
 	});