Allow larger random seeds #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socram8888
force-pushed
the
larger-random
branch
from
250e570 to
961423a
Compare
socram8888
force-pushed
the
larger-random
branch
from
961423a to
8aca221
Compare
|
Looks good, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows specifying larger random seeds. Current value only allows for 10k possible variations, which is quite short considering these boards may contain millions of pictures.
The new value allows for 10^8 variations, so I am more likely to get a truly random image using the Danbooru/Ouroboros API with large data sets.
In order to keep autogenerated seeds short, the JS code that inserts the value will still produce only 4-digit sequences.
This should not cause any compatibility issues as MySQL uses a 32-bit field for the seed, which allows for log10(2**32) = ~9.6 digit seeds. The other engines fall back to the hash DRBG which accept arbitrary lengths.