Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 Support #89

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

React 18 Support #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
43403fc
Update README.md
shirakaba Jul 24, 2021
06af237
chore: update README.md
wSedlacek Jul 30, 2022
5552794
chore: move editorconfig to root
wSedlacek Jul 30, 2022
e1a1ee7
chore: configure prettier to match existing code
wSedlacek Jul 30, 2022
d836d3a
feat: react-nativescript update to nativescript 8 and react 18
wSedlacek Jul 30, 2022
66513ba
refactor(sample): removed sprit kit game example due to missing types
wSedlacek Jul 30, 2022
1c159c5
feat(sample): update to nativescript 8 and react 18
wSedlacek Jul 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 sample/.editorconfig → .editorconfig
View file
Open in desktop
File renamed without changes.
12 changes: 12 additions & 0 deletions .prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"tabWidth": 4,
"printWidth": 140,
"overrides": [
{
"files": "*.json",
"options": {
"tabWidth": 2
}
}
]
}
20 changes: 4 additions & 16 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ tns run android

## Documentation

* [React NativeScript docs](https://react-nativescript.netlify.com)
* [NativeScript docs](https://docs.nativescript.org/start/introduction)
- [React NativeScript docs](https://react-nativescript.netlify.com)
- [NativeScript docs](https://docs.nativescript.org/introduction.html)

## Example real-world app

Expand Down Expand Up @@ -85,7 +85,6 @@ One example is my `rpstrackerrns` issue-tracking example app, which demonstrates
</tbody>
</table>


## Plugins

Although NativeScript lets you write native code inline as JavaScript, you can also write modules purely using native code (e.g. Objective-C and Java), and access the code directly in NativeScript via JavaScript. When a common, cross-platform JavaScript API is provided for such modules, it is called a "plugin", and can be thought of as equivalent to a React Native "native module". NativeScript has a rich ecosystem of these plugins – see the [NativeScript Marketplace](https://market.nativescript.org/?tab=plugins).
Expand Down Expand Up @@ -146,17 +145,6 @@ React NativeScript shares most of the good parts of React Native, but above all
<p>Webpack</p>
</td>
</tr>
<tr>
<td align="center" valign="middle">
<strong>Codebase</strong>
</td>
<td align="center" valign="middle">
<p>Absolutely unfathomable</p>
</td>
<td align="center" valign="middle">
<p>Very approachable to new contributors</p>
</td>
</tr>
<tr>
<td align="center" valign="middle">
<strong>Javascript VM threading</strong>
Expand Down Expand Up @@ -263,7 +251,7 @@ It's based on React, NativeScript Core, and NativeScript Vue, which are each ind

**Can this consume React Native projects?**

No, but it *could* with a lot of hard work. Allowing React NativeScript to run projects that were written for React Native is a huge project, but it's theoretically very possible – it would be a project on exactly the same scale as [React Native Web](https://github.com/necolas/react-native-web). See [react-nativescript-compat-react-native](https://github.com/shirakaba/react-nativescript-compat-react-native) for work towards this, where I've ported part of RNTester as a proof-of-concept... 👩‍🔬👨‍🔬
No, but it _could_ with a lot of hard work. Allowing React NativeScript to run projects that were written for React Native is a huge project, but it's theoretically very possible – it would be a project on exactly the same scale as [React Native Web](https://github.com/necolas/react-native-web). See [react-nativescript-compat-react-native](https://github.com/shirakaba/react-nativescript-compat-react-native) for work towards this, where I've ported part of RNTester as a proof-of-concept... 👩‍🔬👨‍🔬

**Can this consume React Native native modules?**

Expand All @@ -273,4 +261,4 @@ Stanisław Chmiela ([@sjchmiela](https://twitter.com/sjchmiela)) produced a [pro

## Contributing 🙋‍♀️

Ideally get in contact via the [Slack channel](https://nativescriptcommunity.slack.com/messages/CJ2B77CJ1/) before starting any PRs!
Ideally get in contact via the [Discord chanel](https://discord.gg/kcTwmBUuTE) before starting any PRs!
Loading