Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend melee refactors mostly #3964

Open
wants to merge 124 commits into
base: master
Choose a base branch
from

Conversation

FalloutFalcon
Copy link
Member

@FalloutFalcon FalloutFalcon commented Jan 4, 2025

About The Pull Request

alot of diffrenct changes to weapons
including but not limited
differing cool downs
better sounds
no more shield stacking
more levels to the force string as to better communicate damage (toolboxes are now medium force)

many behind the scenes refactors
energy weapons now are subtyped smart (halberds are like 8 lines isntead of like the 70 they used to be)
shields arent all relying on the riot subtype for logic
sledge now has its own type

Why It's Good For The Game

good code and more interesting weapons!

Changelog

🆑
add: melee weapons now support varried cooldowns, we now have fast swinging knives and slow swinging axes for example
add: stamped machetes can now break
add: expanded the range of the force string, toolboxes are now "medium" in accordance to power creep
balance: you now only take the block chance from your best weapon
soundadd: alot of sounds ported from mojave sun
refactor: halberds are now a simple subtype of dswords
refactor: detached some shield code from shield/riot and ported from breaking logic from tg
refactor: gorlex sledgehammers no longer inherit behavoir from axes
/:cl:

@FalloutFalcon FalloutFalcon requested review from a team as code owners January 4, 2025 15:43
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. DME Edit Sprites A bikeshed full of soulless bikes. Sound USSR Anthem 2.66 MB file. Ship Ship successfully tested. Code change Watch something violently break. Ruin Ruin successfully tested. Merge Conflict Use Git Hooks, you're welcome. labels Jan 4, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested. Ship Ship successfully tested. Sound USSR Anthem 2.66 MB file. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant