Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very small pistol tweaks #3938

Closed
wants to merge 2 commits into from
Closed

Conversation

rye-rice
Copy link
Member

About The Pull Request

Makes the ringneck 8 rounds
Makes the commander 12 rounds

Adjust the sprites to match

Why It's Good For The Game

Apogee and I decided this would be better

Changelog

🆑
add: Touches up the ringneck and commander magazine sprites
balance: Ringneck is now 8 rounds and commander is 12 rounds.
/:cl:

@rye-rice rye-rice requested review from FalloutFalcon and a team as code owners December 28, 2024 22:33
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Dec 28, 2024
@rye-rice rye-rice requested review from Apogee-dev and removed request for a team December 28, 2024 22:33
@rye-rice
Copy link
Member Author

@Apogee-dev

@rye-rice rye-rice requested review from a team and removed request for FalloutFalcon December 28, 2024 22:33
Copy link
Contributor

@Apogee-dev Apogee-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm apogee and i approve of this message

@Apogee-dev
Copy link
Contributor

fix the magazine icons though.

@rye-rice
Copy link
Member Author

done, no idea wtf is causing the final fail

@rye-rice rye-rice requested review from Apogee-dev and a team and removed request for a team December 29, 2024 06:53
@@ -31,7 +31,7 @@

/datum/supply_pack/gun/commanders
name = "Commander Pistol Crate"
desc = "Contains a modified Candor 'Commander' pistol, produced by Nanotrasen and chambered in 9mm."
desc = "Contains a high capacity'Commander' pistol, produced by Nanotrasen and chambered in 9mm."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
desc = "Contains a high capacity'Commander' pistol, produced by Nanotrasen and chambered in 9mm."
desc = "Contains a high capacity 'Commander' pistol, produced by Nanotrasen and chambered in 9mm."

@rye-rice
Copy link
Member Author

remaking due to check failure, maybe thats causing it?

@rye-rice rye-rice closed this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants