Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes skirt preferences for Inteq uniforms #3934

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Ical92
Copy link

@Ical92 Ical92 commented Dec 25, 2024

About The Pull Request

Because of how Inteq clothing was pathed, uniforms were failing to get the subtype for skirts meaning they could not be properly selected. Ex. expecting .../corpsman/skirt when it was actually .../skirt/corpsman. This fixes the paths for skirts and updates them on used maps.

Why It's Good For The Game

Lets players actually use Inteq skirtlenecks, rather than failing to retrieve the subtype and falling back to a regular turtleneck.

Changelog

🆑
fix: skirt preferences now work for inteq uniforms
/:cl:

@Ical92 Ical92 requested review from a team as code owners December 25, 2024 23:50
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested. Code change Watch something violently break. labels Dec 25, 2024
@meemofcourse
Copy link
Contributor

i would prefer something similar to alt uniforms where the skirt preference can be defined in the outfit datum but this is good too

@Ical92
Copy link
Author

Ical92 commented Dec 25, 2024

Definitely thought that would be a cleaner solution while fixing this, may work on that next but this works in the meantime

@Ical92
Copy link
Author

Ical92 commented Dec 25, 2024

Bleh, something went wrong with the update script, will fix that (Fixed now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants