Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Great Shiptest IRS Audit (Branch Edition) #3917

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

Geoengi
Copy link
Contributor

@Geoengi Geoengi commented Dec 17, 2024

About The Pull Request

  • Removes the ability to place material coins into slot machines by changing the pay mode; they only work with cash bundles now. Thank @flopppi for this wonderful edit.
  • Slot machines don't announce if you've won a jackpot to the whole sector.
  • The roulette table no longer gets stuck with spinning numbers and now references cash cards over ID cards. Also fixes some grammar relating to its beacon and gives it an activation sound.
  • Vendors no longer ask for ID cards when no account is presented and instead cash cards.

Why It's Good For The Game

So turns out that if you place coins in a slot machine and go to withdraw them or deconstruct the machine, it literally tries to throw infinite coins at your head and kills the server. Obviously, it should not do this.

Consistency in terminology and bug fixes is also good, yes-yes.

Changelog

🆑
fix: Partially fixed persistent overlays on roulette tables.
tweak: Slot machines don't announce who won a jackpot where.
tweak: Replaced references to ID cards with cash cards where applicable.
tweak: The roulette beacon now has an activation sound.
spellcheck: The roulette beacon's description reads better.
code: Slot machines no longer accept material coins due to them nuking the server if withdrawn.
/:cl:

@github-actions github-actions bot added TGUI Code change Watch something violently break. labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. TGUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant