Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faction Cargo: Armor #3887

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

Erikafox
Copy link
Contributor

@Erikafox Erikafox commented Dec 6, 2024

About The Pull Request

Adds a bunch of the stupid armor variations and not stupid hardsuits to cargo for factions to buy.

Removes a bunch of armor cruft like wizard hardsuits. or chronosuits. yeah. chronosuits. those are really in the vogue now.

Adjusts some values on armor / spacesuits to make them a little more unique.

Why It's Good For The Game

buy faction gear good yes yes?

Changelog

🆑
add: You can now purchase most faction's special armor at the outpost.
del: a bunch of wizard bullshit, and also chrono troopers from red alert 2
code: spacesuit_armor has been split into 2 files
/:cl:

@github-actions github-actions bot added DME Edit Code change Watch something violently break. labels Dec 6, 2024
@Erikafox
Copy link
Contributor Author

Erikafox commented Dec 6, 2024

fixed those and a few others.

@Apogee-dev
Copy link
Contributor

The cargo changes are good but the stat changes should be in a separate PR so they don’t get everything else in this PR hung up on them.

@Erikafox
Copy link
Contributor Author

Erikafox commented Dec 6, 2024

i'd agree but i did some flavor changes for this stuff too, so it's bundled together somewhat neatly.

@Apogee-dev
Copy link
Contributor

Apogee-dev commented Dec 7, 2024

Alright well, most of the armor changes are pretty minimal but I’ve got major objections to the sec hardsuit change. It really should not be better than or (nearly) equivalent to a normal armor vest, especially since it comes with limb protection. 20-25 armor would be fine for both the suit and helmet (and please make the armor values the same for both. Matching sets of regular armor do that, hardsuits should too).
Also if you change the armor on sec hardsuits you gotta make sure the indie sec suit (and other sec suit variants) and syndie armored space suits are adjusted accordingly.

code/modules/cargo/packs/spacesuits.dm Outdated Show resolved Hide resolved
code/modules/clothing/spacesuits/hardsuit.dm Outdated Show resolved Hide resolved
Erikafox and others added 2 commits December 12, 2024 00:17
Co-authored-by: Mark Suckerberg <[email protected]>
Signed-off-by: Erika Fox <[email protected]>
Co-authored-by: Mark Suckerberg <[email protected]>
Signed-off-by: Erika Fox <[email protected]>
Copy link
Member

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any price rebalances can be done later tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants