Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Door Speed #3883

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Door Speed #3883

wants to merge 6 commits into from
+199 −152

Conversation

Erikafox
Copy link
Contributor

@Erikafox Erikafox commented Dec 5, 2024

About The Pull Request

refactors some door code
makes it so you can change how fast a door should close with airlock electronics

Why It's Good For The Game

engineering improvement + mapping stuff

Changelog

🆑
add: you can now change how fast a door should close with the door electronics
/:cl:

@github-actions github-actions bot added TGUI Code change Watch something violently break. labels Dec 5, 2024
@Erikafox Erikafox requested a review from a team as a code owner December 5, 2024 21:29
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested. labels Dec 5, 2024
MarkSuckerberg
MarkSuckerberg requested changes Dec 7, 2024
View reviewed changes
Copy link
Member

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely a good start with the TGUI for sure!

code/game/machinery/doors/door.dm Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/AirlockElectronics.js Show resolved Hide resolved
code/game/machinery/doors/airlock_electronics.dm Outdated Show resolved Hide resolved
Erikafox and others added 2 commits December 7, 2024 16:48
@Erikafox @MarkSuckerberg
Update code/game/machinery/doors/door.dm
ee7e7c8 
Co-authored-by: Mark Suckerberg <[email protected]>
Signed-off-by: Erika Fox <[email protected]>
@Erikafox @MarkSuckerberg
Update code/game/machinery/doors/airlock_electronics.dm
4b78266 
Co-authored-by: Mark Suckerberg <[email protected]>
Signed-off-by: Erika Fox <[email protected]>
@thgvr
Copy link
Member

thgvr commented Dec 10, 2024

does this match up with airlock animations still?

@Erikafox
Copy link
Contributor Author

Different kind of door closing. This is the speed at which the door auto closes.

@thgvr
Copy link
Member

thgvr commented Dec 10, 2024

ah, time before it closes? sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkSuckerberg MarkSuckerberg MarkSuckerberg approved these changes

Assignees
No one assigned
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested. TGUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Erikafox @thgvr @MarkSuckerberg