Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laser Misc Changes #3879

Merged
merged 12 commits into from
Dec 12, 2024
Merged

Conversation

generalthrax
Copy link
Contributor

@generalthrax generalthrax commented Dec 4, 2024

About The Pull Request

Makes ordinary lasers / eguns normal sized instead of bulky, and lets you add both them and weapon cells to holsters. Also fixes a singular weapon sprite on Singulo Lab.

Fixes #3790

Why It's Good For The Game

They look like they're handguns and they should fit in holsters too

Changelog

🆑
balance: Lasers / Eguns are now normal-sized
add: Lasers / Eguns now fit in holsters
fix: Sprite issue on Singulo Lab lasercannons

/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Dec 4, 2024
@rye-rice
Copy link
Member

rye-rice commented Dec 4, 2024

yeahh to be honest

lasers are pretty bad at the moment so this seems fine in the meantime until someone rebalances them

@Martinpachu
Copy link
Contributor

yeahh to be honest

lasers are pretty bad at the moment so this seems fine in the meantime until someone rebalances them

sharplite rework

@generalthrax
Copy link
Contributor Author

I'll do some other stuff like add them to holsters and stuff later

@SomeguyManperson
Copy link
Contributor

Needs to account for laser variants that used to be bulky bc a normal sized hades sounds too funny

@Apogee-dev
Copy link
Contributor

Apogee-dev commented Dec 6, 2024

Make sure this doesnt affect previously bulky variants (e-shotgun, hades) or variants by other manufacturers like the eoehomas (which im pretty sure didnt get factionpathed, but if they did there’s certainly others that werent)

@generalthrax
Copy link
Contributor Author

I probably should have mentioned I was planning on getting to that, I didn't finish the pr all the way as I was in round. I'll do that sometime this weekend along with some other convenience things like aforementioned holsters.

@generalthrax generalthrax changed the title Makes lasers normal sized again Laser Misc Changes Dec 10, 2024
@generalthrax generalthrax requested a review from a team as a code owner December 10, 2024 20:24
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested. labels Dec 10, 2024
@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Dec 12, 2024
Merged via the queue into shiptest-ss13:master with commit a97bc3e Dec 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]the NT-LS-1013 has no sprite
7 participants