Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlaws Silicons by Default + Cyborg Fixes #3799

Merged
merged 21 commits into from
Dec 12, 2024

Conversation

Geoengi
Copy link
Contributor

@Geoengi Geoengi commented Nov 17, 2024

About The Pull Request

Changes cyborgs and AIs to start with no laws. Security cyborgs have also seen their hailers removed, and peacekeepers have had their disappearing shield generators fixed. Both of their module select messages have been removed, along with all silicons orders to obey a lawset.

Why It's Good For The Game

For the fixes, the cyborg hailer was only used for playing sounds that were removed as cruft in a previous pr, and the shield icon state was made invisible by a single misplaced character. No laws for silicons are consistent with the setting's ban on artificial slavery. Should please the maintainers in the conversation of this PR.

Changelog

🆑
del: Removes the useless sec hailer from security cyborgs.
del: Removes parts of the popup messages from AI, cyborgs, and certain cyborg modules that implicate default lawsets.
fix: The hyperkinetic dampening projector now changes icon states appropriately.
config: Silicons no longer start with a default lawset.
/:cl:

@github-actions github-actions bot added Config Watch us shake head admins violently until this gets merged. Code change Watch something violently break. labels Nov 17, 2024
@Geoengi
Copy link
Contributor Author

Geoengi commented Nov 17, 2024

As this is one of my largest PRs to date, any and all feedback is appreciated! I understand that this is a big change, and I can adjust anything as requested.

@thgvr
Copy link
Member

thgvr commented Nov 17, 2024

So, here's the thing.

We don't really use any of the silicon laws, nor really have an interest in dealing with them administratively. The repo config isn't up to date with server config, either, which is on us.

The current law we use is:
Satisfy the values of sapient beings.

I don't really have any interest in changing this. A silicon here is considered part of the ship's crew, and isn't really bound to a strict set of laws in our setting. None of these law changes would be used if they were to be merged, and I'd like to keep it that way. Silicon stuff is a headache and generally designed to cause friction with a station's crew - this is not really applicable to us

If you'd like to keep some cyborg changes that's fine, but the law stuff will not be getting merged.

@thgvr thgvr added the Do Not Merge You probably made someone angry, or you're stopping people from getting angry. label Nov 17, 2024
@generalthrax
Copy link
Contributor

What if you just removed the law and have them start purged by default? I'm like 90% sure we're moving away from lawed silicons being a thing anyways, and functionally I don't think anything changes.

@Geoengi
Copy link
Contributor Author

Geoengi commented Nov 17, 2024

What if you just removed the law and have them start purged by default? I'm like 90% sure we're moving away from lawed silicons being a thing anyways, and functionally I don't think anything changes.

@thgvr Would this be a better solution, do you think? If not, I'll scrap all the law stuff.

@Geoengi Geoengi marked this pull request as draft November 17, 2024 21:04
@thgvr
Copy link
Member

thgvr commented Dec 3, 2024

Just making no laws would be fine

@Latentish
Copy link
Member

Once the lore is finished the plan was to switch to no lawing, and lawing being fundamentally taboo. So removal of all laws would be preferable, except by maybe admin intervention or event.

Copy link
Contributor

github-actions bot commented Dec 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Dec 7, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Dec 11, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Dec 11, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Geoengi Geoengi changed the title Substitutes Asimov with Crewsimov + Cyborg fixes. Unlaws Silicons by Default + Cyborg Fixes. Dec 11, 2024
@Geoengi Geoengi marked this pull request as ready for review December 11, 2024 05:59
@Geoengi
Copy link
Contributor Author

Geoengi commented Dec 11, 2024

Once the lore is finished the plan was to switch to no lawing, and lawing being fundamentally taboo. So removal of all laws would be preferable, except by maybe admin intervention or event.

I think this PR plus #3876 would fulfill the intended vision. If there are any oversights that deal with default lawing, I'd be happy to fix them. @Latentish

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Dec 11, 2024
@Geoengi Geoengi changed the title Unlaws Silicons by Default + Cyborg Fixes. Unlaws Silicons by Default + Cyborg Fixes Dec 11, 2024
@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Dec 12, 2024
Merged via the queue into shiptest-ss13:master with commit 561a0cb Dec 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Config Watch us shake head admins violently until this gets merged. Do Not Merge You probably made someone angry, or you're stopping people from getting angry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants