Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gun Zoom Changes #3736

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

Erikafox
Copy link
Contributor

@Erikafox Erikafox commented Nov 11, 2024

About The Pull Request

Makes zooming something every gun can do. Reflavors it to be aiming down the sights of the weapon.
Adds scopes that make you slower while aiming, but also let you aim further.

ports 3 fixes to make this less painful
tgstation/tgstation#64015
tgstation/tgstation#57345
tgstation/tgstation#63654

Why It's Good For The Game

experimentation

Changelog

🆑
add: Scopes!!!
add: All guns now have an implicit ability to aim down sights.
add: aiming now slows you down.
fix: fixes ported from /tg/: projectiles no longer sail into the ether when you fire them at a distance
fix: aiming is now less jank
/:cl:

@github-actions github-actions bot added DME Edit Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Nov 11, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Nov 30, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Nov 30, 2024
@Erikafox Erikafox marked this pull request as ready for review November 30, 2024 21:21
@Erikafox Erikafox requested a review from a team as a code owner November 30, 2024 21:21
@thgvr
Copy link
Member

thgvr commented Dec 3, 2024

Zoom system is way too janky for this

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Dec 4, 2024
@FalloutFalcon FalloutFalcon added the Test Merge Required They'll have to do it for free. label Dec 30, 2024
@FalloutFalcon
Copy link
Member

I pretty much agree with thgvr though I would like to test out the concept cause it could work if our zoom was better.

@Erikafox
Copy link
Contributor Author

zoom, at least here, just got unjanked by an order of magnitude so this would make a good testmerge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Sprites A bikeshed full of soulless bikes. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants