-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Talos and Scarab maints. #3658
Conversation
Those iron brick walls need to be removed, that isn’t really ship construction material. There’s also quite a bit of rust for what is supposed to be a newer ship class in lore, and you tend to lump the rusty walls all together. Spread out the rust spots a bit in isolated single tiles and just use metal walls for the rest. Wires and overall construction are too messy. It’s maints, sure, but this is also a Hardline ship, not Miskilamo, and new construction and that. You also removed all AAC airlocks, either leading into maints or leading to space. You need at least one set, or the wing will gradually depressurize. Unless you want to run pipe all the way to the tips, that’ll be back in their original positions. |
wdym by that? Wing isn't depressurized rn, and there most certainly were no space-leading airlocks in the first place. |
The docking ports at the nose of each wing didn’t have an AAC because the entire wing was depressurized in the past. The AACs instead separated the main part of the ship from maints. Since maints are pressurized now you need AACs on those docking ports regardless of whether or not the airlocks are locked- any airlock separating a pressurized area from a potentially depressurized one needs an AAC. |
Ack, minor issue I missed the first time through. Offset the airlock on the Talos’s starboard docking port one tile south please- with the current design someone dragging a solid object can’t get through that airlock and could even get stuck if they walk down a tile. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Re-opening this, because I do kind of like it. I don't really recall why I closed it either. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request **Talos:** - Makes them more similar style-wise to the Scarab. - Un-spaces them. - Makes them less boring by adding Stuff. ![obraz](https://github.com/user-attachments/assets/42d0a49c-90a6-475d-b47f-98273e3e21d7) **Scarab:** - Makes them less messy and broken. - Makes the airlock an actual airlock. ![obraz](https://github.com/user-attachments/assets/6dd1166b-1e11-4b95-ba17-23b16aea739a) <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game People seem to love the Scarab maint, while hating on the Talos one, so Talos is now more similar. Scarab gets some stuff I missed during actual PR. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: tweak: Talos maints were remapped. They are also no longer spaced. tweak: Scarab maints were tweaked a little. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
About The Pull Request
Talos:
Scarab:
Why It's Good For The Game
People seem to love the Scarab maint, while hating on the Talos one, so Talos is now more similar.
Scarab gets some stuff I missed during actual PR.
Changelog
🆑
tweak: Talos maints were remapped. They are also no longer spaced.
tweak: Scarab maints were tweaked a little.
/:cl: