-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweaks to random spawners #3644
base: master
Are you sure you want to change the base?
tweaks to random spawners #3644
Conversation
Can you split off the repaths to a different pr? It'll probably fuck up a lot of maps that I have a feeling this doesn't address. |
Repaths are breaking a ton of maps. Please make sure they're fixed before merging this and/or split them into a separate PR so the meat of it can go through, because this isn't the first repath that's caused this problem. ideally that particular problem should be addressed before repath PRs are even test merged due to the effect they can have on a round. |
I just skimmed the ruins and none of them use the salvage spawners i repathed. |
scarab is one. split it off so we can get this Fix It As Soon As Possible i dont want another 3 "i got dusted by the die of fate" tickets or seeing people with the double speed jackboots |
Ough, yeah, Scarab isn't fullmerged yet, that would explain it. I think we should be very careful about test merging repaths and map PRs at the same time in the future if the bugged tiles thing is going to be the result every time they conflict. Or just not do that, ever, as a blanket rule. Repath PRs are usually fairly speedy merges and the resulting merge conflicts will put affected maps out of commission until they're fixed, but it's better than things breaking live on the server. |
Repaths, almost never need testmerges. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repathings will continue until morale improves
(please fix checks and merge conflicts)
This PR has been inactive for a month. This means it is at risk of being auto closed in a week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
…to exotic-loot-pool
About The Pull Request
Main part of the pr is tweaking the exotic maint loot to be much less cruft
Few minor repaths
Removal of a few cruft items/spawners
Why It's Good For The Game
Changelog
🆑
add: Wallets now use a random spawner
del: Removed a few cruft items/spawners
balance: Exotic loot is alot less cruft
/:cl: