Skip to content

Commit

Permalink
Small Stat Tweaks (#3695)
Browse files Browse the repository at this point in the history
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Just tweaks the two new stats to be better organized, and adds the total
cost of crate types purchased.

todo: increment cargo purchases stat version to 2
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

Better organized stats to get a better picture of what's happening
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
  • Loading branch information
MarkSuckerberg authored Nov 4, 2024
1 parent 83d8256 commit 4aadf48
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion code/modules/cargo/order.dm
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
src.reason = reason
src.paying_account = paying_account
if(pack)
SSblackbox.record_feedback("tally", "crate_ordered", 1, pack.name)
SSblackbox.record_feedback("nested tally", "crate_ordered", 1, list(pack.name, "amount"))
SSblackbox.record_feedback("nested tally", "crate_ordered", pack.cost, list(pack.name, "cost"))

/datum/supply_order/proc/generateRequisition(turf/T)
var/obj/item/paper/requisition_paper = new(T)
Expand Down
8 changes: 4 additions & 4 deletions code/modules/overmap/missions.dm
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
return ..()

/datum/mission/proc/accept(datum/overmap/ship/controlled/acceptor, turf/accept_loc)
SSblackbox.record_feedback("tally", "mission_accepted", 1, name)
SSblackbox.record_feedback("nested tally", "mission", 1, list(name, "accepted"))
accepted = TRUE
servant = acceptor
LAZYREMOVE(source_outpost.missions, src)
Expand All @@ -64,13 +64,13 @@
return ..()

/datum/mission/proc/turn_in()
SSblackbox.record_feedback("tally", "mission_succeeded", 1, name)
SSblackbox.record_feedback("tally", "mission_payout", value, name)
SSblackbox.record_feedback("nested tally", "mission", 1, list(name, "succeeded"))
SSblackbox.record_feedback("nested tally", "mission", value, list(name, "payout"))
servant.ship_account.adjust_money(value, CREDIT_LOG_MISSION)
qdel(src)

/datum/mission/proc/give_up()
SSblackbox.record_feedback("tally", "mission_abandoned", 1, name)
SSblackbox.record_feedback("nested tally", "mission", 1, list(name, "abandoned"))
qdel(src)

/datum/mission/proc/can_complete()
Expand Down

0 comments on commit 4aadf48

Please sign in to comment.