Svcdependencies auto computing #1683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypsah
force-pushed
the
svcdependencies_auto_computing
branch
from
1231522
to
0525302
Compare
ypsah
force-pushed
the
svcdependencies_auto_computing
branch
3 times, most recently
from
abad064
to
a2cb2e9
Compare
added 4 commits
August 27, 2015 16:35
What:
Create dependencies between services host by host without the need
to write long and dull configuration files.
Why:
Because servicedependencies are rather useful but really complicated
to correctly setup right now, especially on large clusters.
Currently the host_name, dependent_host_name, hostgroup_name and
dependent_hostgroup_name properties do not allow users
to define host by host servicedependencies or service to service
dependencies at once.
How:
Users will just need to define the service and the dependent_service
descriptions in the servicedependency configuration.
The function Servicedependency.explode will then compute the hosts
having both the dependent_service and the service depended on, and for
these hosts a servicedependency will be created.
Example:
With this configuration:
define host{
...
host_name h0
}
define host{
...
host_name h1
}
define service{
...
service_description svc0
host_name h0, h1
}
define service{
...
service_description svc1
host_name h0, h1
}
define servicedependency{
service_description svc0
dependent_service_description svc1
}
We will create these servicedependencies:
define servicedependency{
service_description svc0
dependent_service_description svc1
host_name h0
}
define servicedependency{
service_description svc0
dependent_service_description svc1
host_name h1
}
And:
- Each couple of service/dependent_service will be processed separately
- Tests for the new feature are also in this commit
Using auto-computing of servicedependencies
ypsah
force-pushed
the
svcdependencies_auto_computing
branch
from
a2cb2e9
to
56d4d10
Compare
|
Thanks and sorry for the delay. I4l have a close look for 2.6 (I'm getting PR for 2.4.2 currently) |
|
Thanks for the reply. When you get the chance, please also take a look at this as both have been integrated at the CEA and are working just fine. |
|
This seems legit and a new great feature ! @naparuba , any suggestions ? Can I merge it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is motivated by the fact that servicedependencies are rather useful but really complicated to correctly setup right now, especially on large clusters. Currently the 'host_name', 'dependent_host_name', 'hostgroup_name' and 'dependent_hostgroup_name' properties do not allow users to define host by host servicedependencies or service to service dependencies at once.
The idea is to compute the hosts that have the dependent service and the service depended upon and create a servicedependecy for each one of them.
For more details please look at the message from 3rd commit.