Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration script #81

Open
wants to merge 40 commits into
base: master
Choose a base branch
from

Conversation

swetha-aggidevara
Copy link

No description provided.

Copy link
Collaborator

@aks30 aks30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part reviewed

.env.sample Outdated Show resolved Hide resolved
.env.sample Outdated Show resolved Hide resolved
.env.sample Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
script/api-list/headers.js Outdated Show resolved Hide resolved
script/constant/config.js Outdated Show resolved Hide resolved
script/constant/config.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@aks30 aks30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swetha as discussed connect with Aishwarya and sync up using common env keys and files etc also we will not create v2 APIs but modify existing APIs only.

.env.sample Outdated Show resolved Hide resolved
.env.sample Outdated Show resolved Hide resolved
.env.sample Outdated Show resolved Hide resolved
config/index.js Outdated Show resolved Hide resolved
return {
connect: client.connect(),
client: client,
expiry: 24 * 3600
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swetha-aggidevara What is this expiry for and how it will be used?

config/redisConfig.js Outdated Show resolved Hide resolved
config/redisConfig.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@aks30 aks30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swetha if you can do a brief walk through the steps of migrations, otherwise I don't have many comments on the migration PR.

scripts/creation-portal-migration/server.js Outdated Show resolved Hide resolved
scripts/creation-portal-migration/server.js Outdated Show resolved Hide resolved
scripts/creation-portal-migration/logger.js Show resolved Hide resolved
scripts/creation-portal-migration/api-list/headers.js Outdated Show resolved Hide resolved
scripts/creation-portal-migration/api-list/program.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants