-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration script #81
base: master
Are you sure you want to change the base?
Migration script #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swetha as discussed connect with Aishwarya and sync up using common env keys and files etc also we will not create v2 APIs but modify existing APIs only.
config/redisConfig.js
Outdated
return { | ||
connect: client.connect(), | ||
client: client, | ||
expiry: 24 * 3600 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swetha-aggidevara What is this expiry for and how it will be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swetha if you can do a brief walk through the steps of migrations, otherwise I don't have many comments on the migration PR.
scripts/creation-portal-migration/template/config/questionSet.js
Outdated
Show resolved
Hide resolved
…ey-service into migration-script
…ra/ml-survey-service into migration-script
No description provided.