Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.3 #341

Open
wants to merge 125 commits into
base: release-5.1.0
Choose a base branch
from
Open

5.0.3 #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
125 commits
Select commit Hold shift + click to select a range
915a150
Issue #ED-76 feat:"Native sign-in in Sunbird mobile app"
vpPavithra Sep 2, 2022
d2d0fad
Issue #ED-76 fix:"Removed unwanted packages and update package for co…
vpPavithra Sep 6, 2022
27cbdd5
Issue #ED-76 fix: "package version update"
vpPavithra Sep 6, 2022
12a46d2
Issue #SB-28221 feat: Added custom splashscreen feature.
swayangjit Sep 16, 2022
37113fa
Issue #SB-28221 merge: Merge pull request #3178 from swayangjit/relea…
swayangjit Sep 16, 2022
0b6ba20
Issue #ED-76 merge: Merge pull request #3159 from vpPavithra/release-…
swayangjit Sep 19, 2022
67747f3
Issue #SB-000 merge: Merge branch 'release-5.0.0' into release-5.0.1
swayangjit Sep 19, 2022
c5b7fba
Issue #SB-000 merge: Merge pull request #3179 from swayangjit/release…
swayangjit Sep 19, 2022
8bd9e91
Issue #SB-28221 feat: Updated sb-themes.
swayangjit Sep 19, 2022
6858d1b
Issue #SB-28221 merge: Merge pull request #3180 from swayangjit/relea…
swayangjit Sep 19, 2022
fa67e2a
Issue #ED-76 fix:"Header fix on native login"
vpPavithra Sep 21, 2022
029c035
Issue #ED-76 test:"test cases fix"
vpPavithra Sep 21, 2022
47fbbdd
Issue #SB-000 merge: Merge branch 'release-5.0.0' into release-5.0.1
swayangjit Sep 21, 2022
e08fcd5
Issue #ED-76 merge: Merge pull request #3181 from vpPavithra/release-…
swayangjit Sep 21, 2022
37b37b0
Issue #SB-000 merge: Merge branch 'release-5.0.1' of github.com:Sunbi…
swayangjit Sep 21, 2022
c0a94e5
Issue #SB-000 merge: Merge branch 'release-5.0.0' into release-5.0.1
swayangjit Sep 21, 2022
de5e328
Issue #SB-000 merge: Merge pull request #3182 from swayangjit/releas…
swayangjit Sep 21, 2022
408045b
Issue ED-138 fix:"Updated Package sb-notification"
vpPavithra Sep 23, 2022
f5e64f9
Merge branch 'release-5.0.1' of https://github.com/vpPavithra/Sunbird…
vpPavithra Sep 23, 2022
0ed4ec4
Merge branch 'release-5.0.1' of https://github.com/Sunbird-Ed/Sunbird…
vpPavithra Sep 23, 2022
73bc7fc
Issue #ED-0000 fix: Sonar codesmell fixes
Sep 26, 2022
b2b4100
Issue #SB-0000 test: Unit test for storage permission
Ajoymaity Sep 26, 2022
4c55bf7
Issue #ED-0000 fix: Fixed some test case errors
Sep 27, 2022
55f32be
Merge branch 'release-5.0.1' of https://github.com/Sunbird-Ed/Sunbird…
Sep 27, 2022
bba71db
Issue #ED-0000 fix: Updated Sonar codesmell fixes
Sep 27, 2022
7653a6a
Issue #ED-0000 fix: Updated the test case errors
Sep 27, 2022
b3fbf82
Issue #ED-0000 fix: Fixed the codesmells
Sep 27, 2022
0f22e16
Issue #ED-0000 fix: Fixed codesmells
Sep 27, 2022
58d0b6d
Issue #SB-0000 test: Unit test
Ajoymaity Sep 28, 2022
11c516b
Issue #ED-0000 merge: Merge pull request #3189 from sujithsojan/relea…
swayangjit Sep 29, 2022
2dfff29
Merge branch 'release-5.0.1' of github.com:Sunbird-Ed/SunbirdEd-mobil…
Ajoymaity Sep 29, 2022
fa99c26
Issue #SB-0000 test: Unit test
Ajoymaity Sep 29, 2022
99a3635
Issue #SB-0000 test: Unit test
Ajoymaity Sep 29, 2022
98166b6
Issue #SB-0000 test: UNit test for guest edit page
Ajoymaity Sep 29, 2022
23fc097
Issue #ED-0000 fix:"Updated sonar bug fixes"
vpPavithra Sep 30, 2022
df37635
Merge branch 'release-5.0.1' of https://github.com/Sunbird-Ed/Sunbird…
vpPavithra Sep 30, 2022
4ffc296
Merge branch 'release-5.0.1' of https://github.com/vpPavithra/Sunbird…
vpPavithra Sep 30, 2022
cb7903f
Issue #ED-244 fix: "Download" text in button is displayed in 2 lines …
Sep 30, 2022
0020199
Merge pull request #3188 from vpPavithra/release-5.0.1
swayangjit Oct 6, 2022
75e83d9
Issue #SB-0000 merge: Merge pull request #3190 from Ajoymaity/releas…
swayangjit Oct 6, 2022
7f05024
Issue #ED-244 fix: "Download" text in button is displayed in 2 lines
Oct 6, 2022
cfcd1da
Issue #ED-244 merge: Merge pull request #3194 from sujithsojan/releas…
swayangjit Oct 6, 2022
de38575
Issue #SB-0000 fix: Updated codesmells issues
Oct 6, 2022
53c6261
Merge branch 'release-5.0.1' into release-5.0.1
sujithsojan Oct 6, 2022
0ebbd85
Issue #SB-0000 fix: Updated codesmells issues
Oct 6, 2022
899a455
Merge branch 'release-5.0.1' of https://github.com/Sunbird-Ed/Sunbird…
Oct 6, 2022
068d868
Issue 5.0.2 fix : UI fixes
Oct 7, 2022
7b9be76
Issue #SB-000 merge: Merge branch 'release-5.0.0' into release-5.0.1
swayangjit Oct 10, 2022
5cd36f2
Issue #SB-000 merge: Merge branch 'release-5.0.1' of github.com:Sunbi…
swayangjit Oct 10, 2022
647a177
Issue #SB-000 merge: Merge pull request #3199 from swayangjit/release…
swayangjit Oct 10, 2022
f31d956
ED-225, ED-224
Oct 11, 2022
eee7d0c
Issue #ED-347 fix:player is not visible on screen
vpPavithra Oct 11, 2022
3c99785
Merge branch 'release-5.0.1' of https://github.com/Sunbird-Ed/Sunbird…
vpPavithra Oct 11, 2022
5004c7b
Issue #ED-347 fix:revert a change on player event
vpPavithra Oct 11, 2022
52de2de
Issue ED-41 : Question number mismatch in preview form
Oct 13, 2022
8bf6ce3
Issue #ED-41:fix: Bug fixes
kiranharidas187 Oct 13, 2022
229f760
Merge pull request #334 from shikshalokam/5.0.2
kiranharidas187 Oct 13, 2022
f473cd2
Issue #ED-62:fix: validation ui fix
kiranharidas187 Oct 13, 2022
f22a810
Merge remote-tracking branch 'sunbird/release-5.0.2' into 5.0.2
kiranharidas187 Oct 13, 2022
0156bf5
Merge pull request #335 from shikshalokam/5.0.2
kiranharidas187 Oct 13, 2022
1634a39
Merge pull request #3200 from vpPavithra/release-5.0.1
swayangjit Oct 14, 2022
d3f9340
Merge pull request #3203 from shikshalokam/release-5.0.2
swayangjit Oct 14, 2022
40050e3
Issue #ED-354 fix:Migration fix for cordova-android10
vpPavithra Oct 17, 2022
6db0323
Issue #ED-354 fix:"Migration fix to cordova-android10"
vpPavithra Oct 18, 2022
023015f
Issue #SB-000 merge: Merge branch 'release-5.0.0' into release-5.0.1
swayangjit Oct 18, 2022
8180bc7
Issue #SB-0000 merge: Merge pull request #3196 from sujithsojan/rele…
swayangjit Oct 18, 2022
b6949da
Issue #ED-354 fix:"Migration fix to cordova-android10 - plugin updated"
vpPavithra Oct 18, 2022
126150b
Issue #ED-354 fix:"added the removed plugin file to config.xml"
vpPavithra Oct 18, 2022
b0a6ec9
Issue #SB-000 merge: Merge branch 'release-5.0.0' into release-5.0.1
swayangjit Oct 18, 2022
ae69083
Merge branch 'release-5.0.1' of https://github.com/Sunbird-Ed/Sunbird…
Oct 19, 2022
c700ce8
Issue #ED-0000 fix"Sonar cloud test coverage"
vpPavithra Oct 19, 2022
123d078
Issue #SB-28221 fix: Updated location edit feature
swayangjit Oct 19, 2022
a0d0691
Issue #SB-28221 merge: Merge pull request #3212 from swayangjit/relea…
swayangjit Oct 19, 2022
b1bf536
Issue #SB-28221 fix: Updated location edit feature
swayangjit Oct 20, 2022
6220011
Issue #SB-28221 merge: Merge pull request #3213 from swayangjit/relea…
swayangjit Oct 20, 2022
7085e57
Issue #ED-354 fix:"Migration to android SDK-31"
vpPavithra Oct 20, 2022
cc53ee6
Issue #ED-0000 fix:"test cases updated"
vpPavithra Oct 20, 2022
c8736c3
Merge pull request #3208 from vpPavithra/release-5.0.2_migration
swayangjit Oct 25, 2022
0340007
Issue #ED-000 test:"updated test cases"
vpPavithra Oct 26, 2022
c18a0e3
Issue #SB-0000 test: Updated the test cases
Oct 28, 2022
33bca35
Issue #ED-354 fix: Added script to rename the aab file.
swayangjit Nov 2, 2022
eb41dd9
Issue #ED-354 merge: Merge pull request #3223 from swayangjit/release…
swayangjit Nov 2, 2022
f482c36
Issue 5.0.3 feat : ED-242, ED-243, ED-338
Nov 2, 2022
084c076
Issue #SB-000 merge: Merge branch 'release-5.0.1' of github.com:Sunbi…
swayangjit Nov 2, 2022
f83115e
Issue #SB-000 merge: Merge branch 'release-5.0.0' into release-5.0.1
swayangjit Nov 2, 2022
af92447
Issue #ED-0000 merge: Merge pull request #3214 from vpPavithra/relea…
swayangjit Nov 2, 2022
64f7da4
Issue #SB-0000 merge: Merge pull request #3217 from sujithsojan/rele…
swayangjit Nov 2, 2022
be51440
Issue #SB-000 merge: Merge branch 'release-5.0.1' of github.com:Sunbi…
swayangjit Nov 2, 2022
9cf539c
Issue #SB-000 merge: Merge branch 'release-4.10.2' into release-5.0.1
swayangjit Nov 2, 2022
1fd6b12
Issue #SB-000 merge: Merge pull request #3209 from swayangjit/release…
swayangjit Nov 2, 2022
a13b317
Issue #SB-000 merge: Merge branch 'release-5.0.1' into release-5.0.2
swayangjit Nov 2, 2022
b38f022
Issue #ED-380 fix:Enrollment end date and batch end date fix
Nov 3, 2022
df7dbd5
Issue #ED-380 merge: Merge pull request #3225 from sujithsojan/releas…
swayangjit Nov 3, 2022
c08028e
Issue #SB-000 merge: Merge pull request #3224 from swayangjit/release…
swayangjit Nov 3, 2022
accdeb5
Issue #ED-383 fix: User is not able to deactivate the groups
Nov 3, 2022
9e0400d
Issue #ED-383 merge: Merge pull request #3226 from sujithsojan/relea…
swayangjit Nov 3, 2022
f5ea3d5
Issue #ED-390 fix: telemetry on submit click
Nov 4, 2022
621bf45
Issue #ED-404 fix: Fixed BMG popup is not displaying for admin
Ajoymaity Nov 8, 2022
071ecbf
Issue#ED-0000 fix:Updated camera plugin to support cordova android ve…
vpPavithra Nov 8, 2022
0a74db9
Issue #SB-0000 test: Fixed the test case error
Nov 8, 2022
1645544
Issue #ED-0000 fix:testcases fix
vpPavithra Nov 8, 2022
e8a10a3
Issue#ED-0000 merge: Merge pull request #3231 from vpPavithra/release…
swayangjit Nov 8, 2022
fdaee47
Issues fix: ED-396, ED-405, ED-406, ED-407
Nov 8, 2022
10545b8
Merge pull request #339 from shikshalokam/5.0.2_QA
kiranharidas187 Nov 8, 2022
34a0768
Merge pull request #3232 from shikshalokam/release-5.0.2
swayangjit Nov 9, 2022
c3d5593
Issue #ED-404 merge: Merge pull request #3230 from Ajoymaity/release-…
swayangjit Nov 9, 2022
c26c65c
Merge branch 'release-5.0.2' into release-5.0.2
swayangjit Nov 9, 2022
fcfb5d8
Issue #ED-383 merge: Merge pull request #3227 from sujithsojan/relea…
swayangjit Nov 9, 2022
e552beb
Issue : QA issues
Nov 9, 2022
06a5bbc
Issue : ED-405 : popup issue fix
Nov 9, 2022
a03cc13
Merge pull request #340 from shikshalokam/ED-405
vishwanath1004 Nov 9, 2022
aa5522c
Merge pull request #3234 from shikshalokam/release-5.0.2
swayangjit Nov 10, 2022
c86cf37
Issue #SB-000 merge: Merge branch 'release-5.0.0' into release-5.0.2
swayangjit Nov 18, 2022
0a6c96e
Issue #SB-000 merge: Merge branch 'release-5.0.3' into release-5.0.2
swayangjit Nov 18, 2022
1eb580f
Issue #SB-000 merge: Merge pull request #3250 from swayangjit/releas…
swayangjit Nov 18, 2022
5bd8be9
Issue #ED-0000 fix:"migration fix API31"
vpPavithra Nov 18, 2022
2b7f31a
Issue #ED-000 merge: Merge pull request #3251 from vpPavithra/release…
swayangjit Nov 18, 2022
576dc45
Issue #ED-0000 fix:"Removed the badge plugin from the migration script"
vpPavithra Nov 18, 2022
0b5b477
Issue #ED-0000 merge: Merge pull request #3252 from vpPavithra/releas…
swayangjit Nov 18, 2022
7bcce32
Issue #ED-0000 fix:"Removed the photo-viewer plugin from the migratio…
vpPavithra Nov 18, 2022
230eebe
Issue #ED-0000 fix:"updated script file"
vpPavithra Nov 18, 2022
7c34ca1
Merge pull request #3253 from vpPavithra/release-5.0.2
swayangjit Nov 18, 2022
88de358
Issue #ED-354 fix:"updated script file and config xml"
vpPavithra Nov 18, 2022
9137f0a
Issue #ED-354 merge: Merge pull request #3254 from vpPavithra/release…
swayangjit Nov 18, 2022
f711fa1
Merge branch 'release-5.0.2' into 5.0.3
Nov 25, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build_config
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ cordova-plugin=cordova-plugin-network-information
cordova-plugin=cordova-plugin-statusbar
cordova-plugin=cordova-plugin-webview-checker
cordova-plugin=https://github.com/adriano-di-giovanni/cordova-plugin-shared-preferences.git
cordova-plugin=https://github.com/katzer/cordova-plugin-local-notifications.git
cordova-plugin=https://github.com/Sunbird-Ed/sb-cordova-plugin-fcm.git#release-3.4.0
cordova-plugin=git+https://github.com/fquirin/cordova-plugin-local-notifications.git
cordova-plugin=https://github.com/Sunbird-Ed/sb-cordova-plugin-fcm.git#release-5.0.2
cordova-plugin=cordova-plugin-advanced-http
cordova-plugin=cordova-plugin-android-permissions
cordova-plugin=cordova.plugins.diagnostic
Expand Down
6 changes: 2 additions & 4 deletions config.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<allow-intent href="geo:*" />
<preference name="ScrollEnabled" value="false" />
<preference name="android-minSdkVersion" value="22" />
<preference name="android-targetSdkVersion" value="31" />
<preference name="BackupWebStorage" value="none" />
<preference name="SplashScreenDelay" value="5000" />
<preference name="Orientation" value="portrait" />
Expand Down Expand Up @@ -147,10 +148,7 @@
<plugin name="cordova-plugin-statusbar" spec="^2.4.3" />
<plugin name="cordova-plugin-webview-checker" spec="^1.0.1" />
<plugin name="cordova-plugin-awesome-shared-preferences" spec="https://github.com/adriano-di-giovanni/cordova-plugin-shared-preferences.git" />
<plugin name="cordova-plugin-local-notification" spec="https://github.com/katzer/cordova-plugin-local-notifications.git">
<variable name="ANDROID_SUPPORT_V4_VERSION" value="26.+" />
</plugin>
<plugin name="cordova-plugin-fcm-with-dependecy-updated" spec="https://github.com/Sunbird-Ed/sb-cordova-plugin-fcm.git#release-3.4.0">
<plugin name="cordova-plugin-fcm-with-dependecy-updated" spec="https://github.com/Sunbird-Ed/sb-cordova-plugin-fcm.git#release-5.0.2">
<variable name="FCM_CORE_VERSION" value="16.0.9" />
<variable name="FCM_VERSION" value="18.0.0" />
<variable name="GRADLE_TOOLS_VERSION" value="3.5.0" />
Expand Down
3,073 changes: 1,344 additions & 1,729 deletions package-lock.json

Large diffs are not rendered by default.

16 changes: 9 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@angular/router": "^9.1.13",
"@ionic-native/android-permissions": "^5.30.0",
"@ionic-native/app-version": "^5.15.1",
"@ionic-native/camera": "^5.30.0",
"@ionic-native/camera": "^5.36.0",
"@ionic-native/chooser": "^5.30.0",
"@ionic-native/core": "^5.15.1",
"@ionic-native/device": "^5.15.1",
Expand Down Expand Up @@ -69,12 +69,13 @@
"@project-sunbird/content-player": "4.4.0",
"@project-sunbird/discussions-ui-v8": "2.6.0-beta.2",
"@project-sunbird/sb-dashlet": "1.0.4",
"@project-sunbird/sb-notification": "^5.0.1",
"@project-sunbird/sb-styles": "0.0.9",
"@project-sunbird/sunbird-epub-player-v9": "4.8.1",
"@project-sunbird/sunbird-pdf-player-v9": "4.8.1",
"@project-sunbird/sunbird-quml-player-v9": "5.0.2",
"@project-sunbird/sunbird-video-player-v9": "5.0.4",
"@project-sunbird/sunbird-sdk": "5.0.0",
"@project-sunbird/sunbird-video-player-v9": "5.0.4",
"chart.js": "^2.9.4",
"chartjs-plugin-datalabels": "^0.7.0",
"chartjs-plugin-stacked100": "^0.7.1",
Expand All @@ -88,7 +89,7 @@
"cordova-plugin-androidx-adapter": "^1.1.3",
"cordova-plugin-appavailability": "^0.4.2",
"cordova-plugin-badge": "^0.8.8",
"cordova-plugin-camera": "^5.0.1",
"cordova-plugin-camera": "^6.0.0",
"cordova-plugin-chooser": "^1.3.2",
"cordova-plugin-code-push": "^1.13.1",
"cordova-plugin-device": "^2.0.3",
Expand Down Expand Up @@ -147,7 +148,6 @@
"pouchdb-adapter-cordova-sqlite": "^2.0.7",
"pouchdb-find": "^7.2.2",
"rxjs": "^6.6.3",
"sb-notification": "0.0.2",
"sb-svg2pdf": "0.0.10",
"sb-tag-manager": "^3.9.19",
"tslib": "^1.10.0",
Expand Down Expand Up @@ -201,7 +201,7 @@
"cordova-plugin-fcm-with-dependecy-updated": "git+https://github.com/Sunbird-Ed/sb-cordova-plugin-fcm.git#release-3.4.0",
"cordova-plugin-file-support": "git+https://github.com/project-sunbird/cordova-plugin-file-support.git#release-1.15.0",
"cordova-plugin-inappupdatemanager": "git+https://github.com/subranil/cordova-plugin-inappupdatemanager.git#release-3.7.0",
"cordova-plugin-local-notification": "git+https://github.com/katzer/cordova-plugin-local-notifications.git",
"cordova-plugin-local-notification": "git+https://github.com/fquirin/cordova-plugin-local-notifications.git",
"cordova-plugin-openrap": "git+https://github.com/project-sunbird/cordova-plugin-openrap.git",
"cordova-plugin-proguard": "git+https://github.com/greybax/cordova-plugin-proguard.git",
"cordova-plugin-qr-scanner": "git+https://github.com/project-sunbird/cordova-plugin-qr-scanner.git#release-4.6.0",
Expand Down Expand Up @@ -279,7 +279,9 @@
"cordova-plugin-androidx-adapter": {},
"cordova-plugin-secure-storage-echo": {},
"cordova-plugin-appavailability": {},
"cordova-plugin-camera": {},
"cordova-plugin-camera": {
"ANDROIDX_CORE_VERSION": "1.6.+"
},
"cordova-plugin-filepath": {},
"cordova-plugin-chooser": {},
"cordova-plugin-filepicker": {},
Expand Down Expand Up @@ -369,4 +371,4 @@
"<rootDir>/src/app/manage-learn/"
]
}
}
}
21 changes: 21 additions & 0 deletions scripts/android/android-10-migration-fix.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
#!/bin/bash

const shell = require('child_process').execSync
var pathList = [
"platforms/android/cordova-plugin-badge/app-badge.gradle",
"platforms/android/com-sarriaroman-photoviewer/app-photoviewer.gradle",
"platforms/android/cordova-plugin-code-push/app-build-extras.gradle",
"platforms/android/cordova-plugin-local-notification/app-localnotification.gradle",
]
for (let i = 0; i < pathList.length; i++) {
try {
if(process.platform == "darwin") {
shell(`sed -i "" "s!compile!implementation!g" ${pathList[i]}`)
} else {
shell(`sed -i "s!compile!implementation!g" ${pathList[i]}`)
}
}
catch(err) {
console.log('error on script plugins ', pathList[i] + ' - ' + err);
}
}
14 changes: 13 additions & 1 deletion src/__tests__/setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,19 @@ global.splashscreen = {
markImportDone: () => { },
hide: () => { },
clearPrefs: () => { },
setContent: () => { }
setContent: () => { },
getActions: (data) => {data(JSON.stringify([
{
type: 'TELEMETRY',
payload: 'sample-payload'
}, {
type: 'IMPORT',
payload: 'sample-payload'
}, {
type: 'DEEPLINK',
payload: 'payload'
}
]))}
}

global.codePush = {
Expand Down
6 changes: 5 additions & 1 deletion src/app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -801,6 +801,10 @@ ion-toast.green-toast{
--background: #{map-get($colors, office_green)};
}

ion-toast.red-toast{
--background: #{map-get($colors, vivid_red)};
}

.btn-block {
margin: 0 !important;
position: relative;
Expand Down Expand Up @@ -2151,7 +2155,7 @@ ion-icon.mg-popup-btn-icon.md.hydrated{
}
}
.segment-button-has-label-only.segment-button-layout-icon-top.ion-activatable.ion-activatable-instant.ion-focusable.hydrated.segment-button-checked ion-label {
color: white !important;
color: black !important;
}
}

Expand Down
1 change: 0 additions & 1 deletion src/app/animations/animation-shrink-out-top-right.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export const animationShrinkOutTopRight: AnimationBuilder = (baseEl: HTMLElement
const wrapperAnimation = createAnimation();
const wrapperEl = baseEl.querySelector('.popover-wrapper');
wrapperAnimation.addElement(wrapperEl);
const wrapperElRect = wrapperEl!.getBoundingClientRect();

wrapperAnimation
.beforeStyles({
Expand Down
20 changes: 9 additions & 11 deletions src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ export class AppComponent implements OnInit, AfterViewInit {
}

checkAndroidWebViewVersion() {
var that = this;
let that = this;
plugins['webViewChecker'].getCurrentWebViewPackageInfo()
.then(function (packageInfo) {
that.formAndFrameworkUtilService.getWebviewConfig().then(function (webviewVersion) {
Expand Down Expand Up @@ -332,19 +332,19 @@ export class AppComponent implements OnInit, AfterViewInit {
}

private syncStatus(status) {
let value = new Map();
switch (status) {
case SyncStatus.DOWNLOADING_PACKAGE:
const value = new Map();
value['codepushUpdate'] = 'downloading-package';
break;
case SyncStatus.INSTALLING_UPDATE:
const value1 = new Map();
value1['codepushUpdate'] = 'installing-update';
value['codepushUpdate'] = 'installing-update';
break;
case SyncStatus.ERROR:
const value2 = new Map();
value2['codepushUpdate'] = 'error-in-update';
value['codepushUpdate'] = 'error-in-update';
}
this.telemetryGeneratorService.generateInteractTelemetry(InteractType.OTHER, InteractSubtype.HOTCODE_PUSH_INITIATED,
Environment.HOME, PageId.HOME, null, value);
}

private downloadProgress(downloadProgress) {
Expand Down Expand Up @@ -723,13 +723,13 @@ export class AppComponent implements OnInit, AfterViewInit {
const selectedLanguage = await this.preferences.getString(PreferenceKey.SELECTED_LANGUAGE_CODE).toPromise();
window['segmentation'].SBTagService.pushTag([selectedLanguage], TagPrefixConstants.USER_LANG, true);
if (selectedLanguage) {
await this.translate.use(selectedLanguage);
this.translate.use(selectedLanguage);
}
}

private async makeEntryInSupportFolder() {
return new Promise<void>((resolve => {
(window as any).sbutility.makeEntryInSunbirdSupportFile((result) => {
(window).sbutility.makeEntryInSunbirdSupportFile((result) => {
this.preferences.putString(PreferenceKey.KEY_SUNBIRD_SUPPORT_FILE_PATH, result).toPromise().then();
resolve();
}, () => {
Expand All @@ -749,7 +749,7 @@ export class AppComponent implements OnInit, AfterViewInit {
private async startOpenrapDiscovery(): Promise<undefined> {
if (this.appGlobalService.OPEN_RAPDISCOVERY_ENABLED) {
return new Observable((observer) => {
(window as any).openrap.startDiscovery(
(window).openrap.startDiscovery(
(response: { ip: string, actionType: 'connected' | 'disconnected' }) => {
observer.next(response);
}, (e) => {
Expand Down Expand Up @@ -1071,8 +1071,6 @@ export class AppComponent implements OnInit, AfterViewInit {
this.preferences.addListener(CsClientStorage.TRACE_ID, (value) => {
if (value) {
// show toast
} else {
// do not show the toast.
}
});
}
Expand Down
6 changes: 0 additions & 6 deletions src/app/category-list/category-list-page.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { PreferenceKey } from './../app.constant';
import { Component, Inject, OnDestroy, OnInit } from '@angular/core';
import {
AppHeaderService,
Expand Down Expand Up @@ -31,7 +30,6 @@ import { ContentUtil } from '@app/util/content-util';
import { ProfileConstants, RouterLinks } from '@app/app/app.constant';
import { NavigationService } from '@app/services/navigation-handler.service';
import { ScrollToService } from '@app/services/scroll-to.service';
import { FormConstants } from '@app/app/form.constants';
import { ModalController } from '@ionic/angular';
import { SearchFilterPage } from '@app/app/search-filter/search-filter.page';
import { FormControl, FormGroup } from '@angular/forms';
Expand Down Expand Up @@ -485,7 +483,6 @@ export class CategoryListPage implements OnInit, OnDestroy {
async onPrimaryFacetFilterSelect(primaryFacetFilter: { code: string }, toApply: FilterValue[]) {
const appliedFilterCriteria: ContentSearchCriteria = this.deduceFilterCriteria();
const facetFilter = appliedFilterCriteria.facetFilters.find(f => f.name === primaryFacetFilter.code);
const onSelectedFilter = [];
if (facetFilter) {
facetFilter.values.forEach(facetFilterValue => {
if (toApply.find(apply => facetFilterValue.name === apply.name)) {
Expand All @@ -494,9 +491,6 @@ export class CategoryListPage implements OnInit, OnDestroy {
facetFilterValue.apply = false;
}
});
toApply.forEach((selectedValue) => {
onSelectedFilter.push(selectedValue.name);
});

await this.applyFilter(appliedFilterCriteria, true, toApply);
}
Expand Down
6 changes: 1 addition & 5 deletions src/app/collection-detail-etb/collection-detail-etb.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1325,9 +1325,7 @@ export class CollectionDetailEtbPage implements OnInit {
this.router.navigate([RouterLinks.ACTIVE_DOWNLOADS]);
}

async onFilterMimeTypeChange(val, idx, currentFilter?) {
const values = new Map();
values['filter'] = currentFilter;
async onFilterMimeTypeChange(val, idx, currentFilter?) {
this.activeMimeTypeFilter = val;
this.currentFilter = this.commonUtilService.translateMessage(currentFilter);
this.mimeTypes.forEach((type) => {
Expand Down Expand Up @@ -1359,8 +1357,6 @@ export class CollectionDetailEtbPage implements OnInit {
this.shownGroups = undefined;
this.navService.navigateTo([`/${RouterLinks.COLLECTION_DETAIL_ETB}/${RouterLinks.TEXTBOOK_TOC}`],
{ childrenData: this.childrenData, parentId: this.identifier });
const values = new Map();
values['selectChapterVisible'] = this.isChapterVisible;
this.telemetryGeneratorService.generateInteractTelemetry(
InteractType.TOUCH,
InteractSubtype.DROPDOWN_CLICKED,
Expand Down
4 changes: 3 additions & 1 deletion src/app/collection-detail-etb/textbook-toc-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ export class TextbookTocService {
};

constructor(
) { }
) {
console.log('textbook-toc-service');
}

setTextbookIds(textbookIds) {
this.textbookIds = textbookIds;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { filter, map } from 'rxjs/operators';
import {
CachedItemRequestSourceFrom,
CorrelationData, DownloadEventType, DownloadProgress, DownloadService,
EventNamespace, EventsBusService, NotificationService as PushNotificationService, NotificationStatus,
EventNamespace, EventsBusService, NotificationService as PushNotificationService,
Profile, ProfileService, ProfileType,
ServerProfile, SharedPreferences, UserFeedStatus
} from 'sunbird-sdk';
Expand Down Expand Up @@ -283,7 +283,6 @@ export class ApplicationHeaderComponent implements OnInit, OnDestroy {
}

emitSideMenuItemEvent($event, menuItem) {
// this.toggleMenu();
this.menuCtrl.close().then(() => {
this.sideMenuItemEvent.emit({ menuItem });
}).catch((e) => {
Expand Down
Loading