Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemons to indicate reason for termination #183

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Daemons to indicate reason for termination #183

merged 3 commits into from
Jan 9, 2025

Conversation

shikokuchuo
Copy link
Owner

@shikokuchuo shikokuchuo commented Jan 8, 2025

Demons now always break cleanly (rather than through an error), allowing an exit value to be returned.

@shikokuchuo
Copy link
Owner Author

Required as crew logs output: #168 (comment).

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.31%. Comparing base (1a55e79) to head (8503d87).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/daemon.R 80.95% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   98.74%   98.31%   -0.43%     
==========================================
  Files           9        9              
  Lines         877      892      +15     
==========================================
+ Hits          866      877      +11     
- Misses         11       15       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shikokuchuo shikokuchuo changed the title Directly close pipes from dispatcher Daemons to indicate reason for termination Jan 9, 2025
@shikokuchuo shikokuchuo merged commit 7eb8bb4 into main Jan 9, 2025
19 checks passed
@shikokuchuo shikokuchuo deleted the dev branch January 9, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants