Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mirai_map() interface #181

Closed
wants to merge 3 commits into from
Closed

Improve mirai_map() interface #181

wants to merge 3 commits into from

Conversation

shikokuchuo
Copy link
Owner

Allow use of ... to pass in constant variables in exactly the same manner as base::lapply() and purrr::map().

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (2d2f6d7) to head (b918f21).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files           9        9           
  Lines         863      863           
=======================================
  Hits          852      852           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shikokuchuo shikokuchuo marked this pull request as draft January 8, 2025 09:50
@shikokuchuo
Copy link
Owner Author

As the tidyverse recommendation is now to use anonymous functions instead of the '...' to pass in constant arguments, there is not a great incentive to provide the exact same interface.

The existing interface is consistent with mirai() with ... being global variables.

@shikokuchuo shikokuchuo closed this Jan 8, 2025
@shikokuchuo shikokuchuo deleted the map branch January 8, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants