Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Serialization Registration #180

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Updates Serialization Registration #180

merged 3 commits into from
Jan 6, 2025

Conversation

shikokuchuo
Copy link
Owner

The serialization configuration is now supplied to the 'serial' argument at daemons(), and this is automatically registered for all daemons (via dispatcher) without needing to be specified in each daemon() call.

This takes advantage of the new dispatcher architecture in mirai v2, which allows us to send the configurations as daemons connect.

There is no longer any reliance on an everywhere() call, thus allowing easy upscaling and downscaling of connected daemons, as we discussed @wlandau.

@shikokuchuo shikokuchuo added the enhancement New feature or request label Jan 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.82%. Comparing base (2c10329) to head (3e2a37c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   98.69%   98.82%   +0.12%     
==========================================
  Files           9        9              
  Lines         843      849       +6     
==========================================
+ Hits          832      839       +7     
+ Misses         11       10       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shikokuchuo shikokuchuo merged commit 5660bfc into main Jan 6, 2025
10 checks passed
@shikokuchuo shikokuchuo deleted the serial branch January 6, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants