Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow control over whether to reset daemons settings #154

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

shikokuchuo
Copy link
Owner

Adds argument 'force'.

Defaults to TRUE so no change in existing behaviour, although this was only brought in fairly recently in mirai 1.1.0.

The previous behaviour had the advantage of "being explicit", but introduced a behavioural dependency on past actions which could be confusing for interactive use.

Adding this setting improves behaviour for programmatic use, where the presumption is to set force = FALSE.

For #137, packages using mirai could then reliably use this without overriding any settings explicitly specified by users outside of their packages.

@shikokuchuo shikokuchuo self-assigned this Sep 16, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.71%. Comparing base (c260d7e) to head (a9d57ce).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files           9        9           
  Lines         699      700    +1     
=======================================
+ Hits          697      698    +1     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shikokuchuo shikokuchuo merged commit 57e0bc4 into main Sep 16, 2024
7 checks passed
@shikokuchuo shikokuchuo deleted the daemons branch September 16, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants