Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes by create-pull-request action #37

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

shijl0925
Copy link
Owner

@shijl0925 shijl0925 commented Dec 24, 2024

Automated changes by create-pull-request GitHub action

Summary by Sourcery

更新允许的指标列表并修复与webhooks相关的类型问题。

错误修复:

  • 修复与webhooks相关的类型问题,其中hasSecret是一个字符串,现在是一个布尔值。

增强功能:

  • 更新允许的指标列表。
Original summary in English

Summary by Sourcery

Update the allowed metrics list and fix a type issue with webhooks.

Bug Fixes:

  • Fix a type issue with webhooks where hasSecret was a string, now it is a boolean.

Enhancements:

  • Update the allowed metrics list.

Copy link

sourcery-ai bot commented Dec 24, 2024

审核者指南 by Sourcery

此拉取请求在特定文件中的列表中重新排序了元素。未引入逻辑更改。

显示更新的 webhook 结构的类图

classDiagram
    class ListResponse {
        +Webhooks[] webhooks
    }
    class Webhook {
        +bool hasSecret
        +string key
        +string name
        +string url
    }
    ListResponse *-- Webhook
    note for Webhook "将 hasSecret 从字符串类型更改为布尔类型"
Loading

文件级别更改

更改 详情 文件
在质量门条件请求和响应中重新排序了禁止的指标。
  • CreateConditionRequestShowResponseUpdateConditionRequest 结构中,禁止的指标顺序从 alert_statussecurity_hotspotsnew_security_hotspots 更改为 alert_statusnew_security_hotspotssecurity_hotspots
sonarqube/qualitygates/qualitygates_gen.go
在组件树请求中重新排序了指标键。
  • ComponentTreeRequest 结构中,DATA 类型支持的指标键顺序从 security_issuesmaintainability_issuesreliability_issuesnew_maintainability_issuesnew_security_issuesnew_reliability_issues 更改为 new_maintainability_issuesreliability_issuesmaintainability_issuessecurity_issuesnew_reliability_issuesnew_security_issues
sonarqube/measures/measures_gen.go
更改了 webhook 密钥类型。
  • ListResponse 结构中,HasSecret 字段从字符串类型更改为布尔类型。
sonarqube/webhooks/webhooks_gen.go

提示和命令

与 Sourcery 互动

  • 触发新审核: 在拉取请求中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审核评论。
  • 从审核评论生成 GitHub 问题: 通过回复审核评论请求 Sourcery 创建一个问题。
  • 生成拉取请求标题: 在拉取请求标题的任何地方写 @sourcery-ai 以随时生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任何地方写 @sourcery-ai summary 以随时生成 PR 摘要。您也可以使用此命令指定摘要应插入的位置。

自定义您的体验

访问您的仪表板以:

  • 启用或禁用审核功能,如 Sourcery 生成的拉取请求摘要、审核者指南等。
  • 更改审核语言。
  • 添加、删除或编辑自定义审核说明。
  • 调整其他审核设置。

获取帮助

Original review guide in English

Reviewer's Guide by Sourcery

This pull request reorders elements in lists within specific files. No logic changes were introduced.

Class diagram showing updated webhook structure

classDiagram
    class ListResponse {
        +Webhooks[] webhooks
    }
    class Webhook {
        +bool hasSecret
        +string key
        +string name
        +string url
    }
    ListResponse *-- Webhook
    note for Webhook "Changed hasSecret from string to bool type"
Loading

File-Level Changes

Change Details Files
Reordered forbidden metrics in quality gate condition requests and responses.
  • The order of forbidden metrics in the CreateConditionRequest, ShowResponse, and UpdateConditionRequest structs was changed from alert_status, security_hotspots, new_security_hotspots to alert_status, new_security_hotspots, security_hotspots.
sonarqube/qualitygates/qualitygates_gen.go
Reordered metric keys in component tree requests.
  • The order of supported metric keys for the DATA type in the ComponentTreeRequest struct was changed from security_issues, maintainability_issues, reliability_issues, new_maintainability_issues, new_security_issues, new_reliability_issues to new_maintainability_issues, reliability_issues, maintainability_issues, security_issues, new_reliability_issues, new_security_issues.
sonarqube/measures/measures_gen.go
Changed webhook secret type.
  • The HasSecret field in the ListResponse struct was changed from a string type to a boolean type.
sonarqube/webhooks/webhooks_gen.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

deepsource-io bot commented Dec 24, 2024

Here's the code health analysis summary for commits c7bb1ce..52e58e0. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shijl0925 - 我已经审查了你的更改,它们看起来很棒!

这是我在审查期间查看的内容
  • 🟢 一般问题:一切看起来都很好
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟢 复杂性:一切看起来都很好
  • 🟢 文档:一切看起来都很好

Sourcery 对于开源是免费的 - 如果你喜欢我们的审查,请考虑分享它们 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用反馈来改进你的审查。
Original comment in English

Hey @shijl0925 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@shijl0925 shijl0925 merged commit 3bb4c30 into master Dec 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant