Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes by create-pull-request action #36

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

shijl0925
Copy link
Owner

@shijl0925 shijl0925 commented Dec 21, 2024

Automated changes by create-pull-request GitHub action

Copy link

sourcery-ai bot commented Dec 21, 2024

审核指南由 Sourcery 提供

此拉取请求更新了注释中的 URL,以反映新的文档结构,并重新排序了注释中的指标,以在多个文件中保持一致性。

SonarQube API 中更新的请求类型的类图

classDiagram
    class ListRequest {
        +String project
    }
    note for ListRequest "更新了文档 URL"

    class SetRequest {
        +String branch
        +String project
        +String type
        +String value
    }
    note for SetRequest "更新了文档 URL"

    class ShowRequest {
        +String branch
        +String project
    }
    note for ShowRequest "更新了文档 URL"

    class CreateConditionRequest {
        +String error
        +String gateName
        +String metric
        +String op
    }
    note for CreateConditionRequest "重新排序了禁止的指标"

    class ComponentTreeRequest {
        +String asc
        +String branch
        +String component
        +String metricKeys
        +String metricPeriodSort
        +String metricSort
        +String metricSortFilter
    }
    note for ComponentTreeRequest "重新排序了支持的指标"
Loading

文件级别的更改

更改 详情 文件
更新了注释中的 URL 以反映新的文档结构。
  • 更改了 ListRequest 注释中的 URL。
  • 更改了 SetRequest 注释中的 URL。
  • 更改了 ShowRequest 注释中的 URL。
  • 更改了 UnsetRequest 注释中的 URL。
sonarqube/new_code_periods/new_code_periods_gen.go
更新了注释中的 URL 以反映新的文档结构。
  • 更改了 List 注释中的 URL。
  • 更改了 Set 注释中的 URL。
  • 更改了 Show 注释中的 URL。
  • 更改了 Unset 注释中的 URL。
sonarqube/new_code_periods_gen.go
重新排序了注释中的禁止指标以保持一致性。
  • 重新排序了 CreateConditionRequest 注释中的禁止指标。
  • 重新排序了 UpdateConditionRequest 注释中的禁止指标。
sonarqube/qualitygates/qualitygates_gen.go
重新排序了注释中的支持指标以保持一致性。
  • 重新排序了 ComponentTreeRequest 注释中的支持指标。
sonarqube/measures/measures_gen.go

提示和命令

与 Sourcery 互动

  • 触发新审核: 在拉取请求中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审核评论。
  • 从审核评论生成 GitHub 问题: 通过回复审核评论请求 Sourcery 创建一个问题。
  • 生成拉取请求标题: 在拉取请求标题的任何地方写 @sourcery-ai 以随时生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任何地方写 @sourcery-ai summary 以随时生成 PR 摘要。您也可以使用此命令指定摘要应插入的位置。

自定义您的体验

访问您的仪表板以:

  • 启用或禁用审核功能,例如 Sourcery 生成的拉取请求摘要、审核指南等。
  • 更改审核语言。
  • 添加、删除或编辑自定义审核说明。
  • 调整其他审核设置。

获取帮助

Original review guide in English

Reviewer's Guide by Sourcery

This pull request updates URLs in comments to reflect a new documentation structure and reorders metrics in comments for consistency across several files.

Class diagram showing the updated request types in SonarQube API

classDiagram
    class ListRequest {
        +String project
    }
    note for ListRequest "Updated documentation URL"

    class SetRequest {
        +String branch
        +String project
        +String type
        +String value
    }
    note for SetRequest "Updated documentation URL"

    class ShowRequest {
        +String branch
        +String project
    }
    note for ShowRequest "Updated documentation URL"

    class CreateConditionRequest {
        +String error
        +String gateName
        +String metric
        +String op
    }
    note for CreateConditionRequest "Reordered forbidden metrics"

    class ComponentTreeRequest {
        +String asc
        +String branch
        +String component
        +String metricKeys
        +String metricPeriodSort
        +String metricSort
        +String metricSortFilter
    }
    note for ComponentTreeRequest "Reordered supported metrics"
Loading

File-Level Changes

Change Details Files
Updated URLs in comments to reflect new documentation structure.
  • Changed URL in ListRequest comment.
  • Changed URL in SetRequest comment.
  • Changed URL in ShowRequest comment.
  • Changed URL in UnsetRequest comment.
sonarqube/new_code_periods/new_code_periods_gen.go
Updated URLs in comments to reflect new documentation structure.
  • Changed URL in List comment.
  • Changed URL in Set comment.
  • Changed URL in Show comment.
  • Changed URL in Unset comment.
sonarqube/new_code_periods_gen.go
Reordered forbidden metrics in comments for consistency.
  • Reordered forbidden metrics in CreateConditionRequest comment.
  • Reordered forbidden metrics in UpdateConditionRequest comment.
sonarqube/qualitygates/qualitygates_gen.go
Reordered supported metrics in comments for consistency.
  • Reordered supported metrics in ComponentTreeRequest comment.
sonarqube/measures/measures_gen.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

deepsource-io bot commented Dec 21, 2024

Here's the code health analysis summary for commits 46a1d4b..8062006. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shijl0925 - 我已经审查了你的更改,它们看起来很棒!

这是我在审查期间查看的内容
  • 🟢 一般问题:一切看起来都很好
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟢 复杂性:一切看起来都很好
  • 🟢 文档:一切看起来都很好

Sourcery 对于开源是免费的 - 如果你喜欢我们的审查,请考虑分享它们 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用反馈来改进你的审查。
Original comment in English

Hey @shijl0925 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@shijl0925 shijl0925 force-pushed the create-pull-request/patch branch from 08d122b to c181519 Compare December 22, 2024 02:52
@shijl0925 shijl0925 force-pushed the create-pull-request/patch branch from c181519 to 8062006 Compare December 23, 2024 02:48
@shijl0925 shijl0925 merged commit c7bb1ce into master Dec 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant