-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes by create-pull-request action #36
Conversation
审核指南由 Sourcery 提供此拉取请求更新了注释中的 URL,以反映新的文档结构,并重新排序了注释中的指标,以在多个文件中保持一致性。 SonarQube API 中更新的请求类型的类图classDiagram
class ListRequest {
+String project
}
note for ListRequest "更新了文档 URL"
class SetRequest {
+String branch
+String project
+String type
+String value
}
note for SetRequest "更新了文档 URL"
class ShowRequest {
+String branch
+String project
}
note for ShowRequest "更新了文档 URL"
class CreateConditionRequest {
+String error
+String gateName
+String metric
+String op
}
note for CreateConditionRequest "重新排序了禁止的指标"
class ComponentTreeRequest {
+String asc
+String branch
+String component
+String metricKeys
+String metricPeriodSort
+String metricSort
+String metricSortFilter
}
note for ComponentTreeRequest "重新排序了支持的指标"
文件级别的更改
提示和命令与 Sourcery 互动
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request updates URLs in comments to reflect a new documentation structure and reorders metrics in comments for consistency across several files. Class diagram showing the updated request types in SonarQube APIclassDiagram
class ListRequest {
+String project
}
note for ListRequest "Updated documentation URL"
class SetRequest {
+String branch
+String project
+String type
+String value
}
note for SetRequest "Updated documentation URL"
class ShowRequest {
+String branch
+String project
}
note for ShowRequest "Updated documentation URL"
class CreateConditionRequest {
+String error
+String gateName
+String metric
+String op
}
note for CreateConditionRequest "Reordered forbidden metrics"
class ComponentTreeRequest {
+String asc
+String branch
+String component
+String metricKeys
+String metricPeriodSort
+String metricSort
+String metricSortFilter
}
note for ComponentTreeRequest "Reordered supported metrics"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @shijl0925 - 我已经审查了你的更改,它们看起来很棒!
这是我在审查期间查看的内容
- 🟢 一般问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用反馈来改进你的审查。
Original comment in English
Hey @shijl0925 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
08d122b
to
c181519
Compare
c181519
to
8062006
Compare
Quality Gate passedIssues Measures |
Automated changes by create-pull-request GitHub action