Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes by create-pull-request action #33

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

shijl0925
Copy link
Owner

@shijl0925 shijl0925 commented Dec 12, 2024

Automated changes by create-pull-request GitHub action

Summary by Sourcery

增强功能:

  • 在 ActivateRulesRequest、DeactivateRulesRequest 和 SearchRequest 结构中添加 'active_impactSeverities' 字段,以支持按质量配置文件中规则的影响严重性进行过滤。
Original summary in English

Summary by Sourcery

Enhancements:

  • Add 'active_impactSeverities' field to ActivateRulesRequest, DeactivateRulesRequest, and SearchRequest structs to support filtering by impact severity of rules in quality profiles.

Copy link

sourcery-ai bot commented Dec 12, 2024

审核者指南由 Sourcery 提供

此 PR 在多个请求结构中添加了对新字段 active_impactSeverities 的支持,并更新了规则 API 的文档。这些更改与 SonarQube 即将发布的 2025.1 和 2025.2 版本相关,引入了基于影响严重性过滤规则的新功能。

更新请求结构的类图

classDiagram
    class ActivateRulesRequest {
        +string Activation
        +string ActiveImpactSeverities
        +string ActiveSeverities
        +string Asc
        +string AvailableSince
    }
    class DeactivateRulesRequest {
        +string Activation
        +string ActiveImpactSeverities
        +string ActiveSeverities
        +string Asc
        +string AvailableSince
    }
    class SearchRequest {
        +string Activation
        +string ActiveImpactSeverities
        +string ActiveSeverities
        +string Asc
        +string AvailableSince
    }
    note for ActivateRulesRequest "添加了 ActiveImpactSeverities 以根据影响严重性进行过滤。"
    note for DeactivateRulesRequest "添加了 ActiveImpactSeverities 以根据影响严重性进行过滤。"
    note for SearchRequest "添加了 ActiveImpactSeverities 以根据影响严重性进行过滤。"
Loading

文件级更改

更改 详情 文件
在请求结构中添加了用于影响严重性过滤的新字段
  • 在 ActivateRulesRequest 中添加了带有表单标签的 ActiveImpactSeverities 字段
  • 在 DeactivateRulesRequest 中添加了带有表单标签的 ActiveImpactSeverities 字段
  • 在 SearchRequest 中添加了带有 URL 标签的 ActiveImpactSeverities 字段
sonarqube/qualityprofiles/qualityprofiles_gen.go
sonarqube/rules/rules_gen.go
使用新的 facet 信息更新了 API 文档
  • 在 2025.2 版本中为新的 'active_impactSeverities' facet 添加了变更日志条目
sonarqube/rules_gen.go

提示和命令

与 Sourcery 互动

  • 触发新审核: 在拉取请求上评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审核评论。
  • 从审核评论生成 GitHub 问题: 通过回复审核评论请求 Sourcery 创建问题。
  • 生成拉取请求标题: 在拉取请求标题的任何位置写 @sourcery-ai 以随时生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任何位置写 @sourcery-ai summary 以随时生成 PR 摘要。您也可以使用此命令指定摘要应插入的位置。

自定义您的体验

访问您的仪表板以:

  • 启用或禁用审核功能,例如 Sourcery 生成的拉取请求摘要、审核者指南等。
  • 更改审核语言。
  • 添加、删除或编辑自定义审核说明。
  • 调整其他审核设置。

获取帮助

Original review guide in English

Reviewer's Guide by Sourcery

This PR adds support for a new field active_impactSeverities in multiple request structs and updates documentation for the Rules API. The changes are related to SonarQube's upcoming 2025.1 and 2025.2 releases, introducing new functionality for filtering rules based on their impact severities.

Class diagram for updated request structs

classDiagram
    class ActivateRulesRequest {
        +string Activation
        +string ActiveImpactSeverities
        +string ActiveSeverities
        +string Asc
        +string AvailableSince
    }
    class DeactivateRulesRequest {
        +string Activation
        +string ActiveImpactSeverities
        +string ActiveSeverities
        +string Asc
        +string AvailableSince
    }
    class SearchRequest {
        +string Activation
        +string ActiveImpactSeverities
        +string ActiveSeverities
        +string Asc
        +string AvailableSince
    }
    note for ActivateRulesRequest "Added ActiveImpactSeverities for filtering by impact severity."
    note for DeactivateRulesRequest "Added ActiveImpactSeverities for filtering by impact severity."
    note for SearchRequest "Added ActiveImpactSeverities for filtering by impact severity."
Loading

File-Level Changes

Change Details Files
Added new field for impact severity filtering in request structs
  • Added ActiveImpactSeverities field with form tag in ActivateRulesRequest
  • Added ActiveImpactSeverities field with form tag in DeactivateRulesRequest
  • Added ActiveImpactSeverities field with url tag in SearchRequest
sonarqube/qualityprofiles/qualityprofiles_gen.go
sonarqube/rules/rules_gen.go
Updated API documentation with new facet information
  • Added changelog entry for new 'active_impactSeverities' facet in version 2025.2
sonarqube/rules_gen.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

deepsource-io bot commented Dec 12, 2024

Here's the code health analysis summary for commits f66165f..0b03526. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shijl0925 - 我已经审查了你的更改 - 这里有一些反馈:

总体评论

  • 在新字段标签中,'active_' 和 'impactSeverities' 之间的空格不一致。请考虑将空格标准化以匹配代码库中的其他字段。
这是我在审查期间查看的内容
  • 🟢 一般问题:一切看起来都很好
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟢 复杂性:一切看起来都很好
  • 🟢 文档:一切看起来都很好

Sourcery 对开源项目免费 - 如果你喜欢我们的评论,请考虑分享它们 ✨
帮助我变得更有用!请点击每条评论上的 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English

Hey @shijl0925 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • There's an inconsistent space in the new field tags between 'active_' and 'impactSeverities'. Consider standardizing the spacing to match other fields in the codebase.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@shijl0925 shijl0925 merged commit 285e19c into master Dec 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant