-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes by create-pull-request action #33
Conversation
审核者指南由 Sourcery 提供此 PR 在多个请求结构中添加了对新字段 更新请求结构的类图classDiagram
class ActivateRulesRequest {
+string Activation
+string ActiveImpactSeverities
+string ActiveSeverities
+string Asc
+string AvailableSince
}
class DeactivateRulesRequest {
+string Activation
+string ActiveImpactSeverities
+string ActiveSeverities
+string Asc
+string AvailableSince
}
class SearchRequest {
+string Activation
+string ActiveImpactSeverities
+string ActiveSeverities
+string Asc
+string AvailableSince
}
note for ActivateRulesRequest "添加了 ActiveImpactSeverities 以根据影响严重性进行过滤。"
note for DeactivateRulesRequest "添加了 ActiveImpactSeverities 以根据影响严重性进行过滤。"
note for SearchRequest "添加了 ActiveImpactSeverities 以根据影响严重性进行过滤。"
文件级更改
提示和命令与 Sourcery 互动
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis PR adds support for a new field Class diagram for updated request structsclassDiagram
class ActivateRulesRequest {
+string Activation
+string ActiveImpactSeverities
+string ActiveSeverities
+string Asc
+string AvailableSince
}
class DeactivateRulesRequest {
+string Activation
+string ActiveImpactSeverities
+string ActiveSeverities
+string Asc
+string AvailableSince
}
class SearchRequest {
+string Activation
+string ActiveImpactSeverities
+string ActiveSeverities
+string Asc
+string AvailableSince
}
note for ActivateRulesRequest "Added ActiveImpactSeverities for filtering by impact severity."
note for DeactivateRulesRequest "Added ActiveImpactSeverities for filtering by impact severity."
note for SearchRequest "Added ActiveImpactSeverities for filtering by impact severity."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Quality Gate passedIssues Measures |
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗨 @shijl0925 - 我已经审查了你的更改 - 这里有一些反馈:
总体评论:
- 在新字段标签中,'active_' 和 'impactSeverities' 之间的空格不一致。请考虑将空格标准化以匹配代码库中的其他字段。
这是我在审查期间查看的内容
- 🟢 一般问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请点击每条评论上的 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English
Hey @shijl0925 - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's an inconsistent space in the new field tags between 'active_' and 'impactSeverities'. Consider standardizing the spacing to match other fields in the codebase.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Automated changes by create-pull-request GitHub action
Summary by Sourcery
增强功能:
Original summary in English
Summary by Sourcery
Enhancements: